AP_HAL_ChibiOS: add hwdef for LongBowF405WING #27009

HiRCBro · 2024-05-07T14:55:28Z

hi
lefeirc PR new board with F405

magicrub

Looks pretty good, thanks! This needs a bootloader. You can compile it by running:
./Tools/scripts/build_bootloaders.py LongBowF405WING

libraries/AP_HAL_ChibiOS/hwdef/LongBowF405WING/hwdef.dat

magicrub · 2024-05-07T15:39:14Z

The commits should also be squashed

tridge · 2024-05-07T19:42:01Z

@HiRCBro I've fixed up the commits in your PR

Hwurzburg · 2024-05-07T22:44:22Z

In order to review I will need pinout/board image.....also, any UART intended for RC operation needs DMA so UART2 in alt configuration will not support CRSF/ELRS and perhaps even SRXL2 ptotocols....so those need to be on another UART...but no others have full DMA either...so RC protocols using bidir serial will have an issue with current definition I beleive

Hwurzburg · 2024-05-07T23:56:04Z

the pinnout of each back side jst-gh connector is missing, labeled solder pads are clear, but what signals are in each JST-GH are not indicated on the back....

HiRCBro · 2024-05-08T01:17:45Z

In order to review I will need pinout/board image.....also, any UART intended for RC operation needs DMA so UART2 in alt configuration will not support CRSF/ELRS and perhaps even SRXL2 ptotocols....so those need to be on another UART...but no others have full DMA either...so RC protocols using bidir serial will have an issue with current definition I beleive

SBUS connect to UART2 with an inverter, if you use SBUS then UART2 cant work. if you use CRSF you cant connect to SBUS you need connect to UART2 or other UART

Hwurzburg · 2024-05-08T01:55:33Z

UART2 and all other UARTs do not have full DMA required for CRSF/ELRS for sure...so you cant make those RC systems work reliably with this hwdef

HiRCBro · 2024-05-08T02:05:11Z

UART2 and all other UARTs do not have full DMA required for CRSF/ELRS for sure...so you cant make those RC systems work reliably with this hwdef

So i need change
PA2 USART2_TX USART2 NODMA
PA3 USART2_RX USART2 NODMA ALT(1)
to:
PA2 USART2_TX USART2
PA3 USART2_RX USART2ALT(1)
？

Hwurzburg · 2024-05-08T02:11:12Z

unfortunately dma does not get assigned to alternate function pins....so that wont do it....I dont know of a way to do it on a uart whose primary pin function is RCINT for RC .....best to get one of the other UARTs DMA enabled....UART6 unfortunately was not assigned a DMA channel in the resolver....maybe @tridge can make a suggestion, or you cna play with NODMA on some UARTS and see what the resolver produces for the others....you have to look at the hwdef.h file in the build directory after to waf configure for you board

HiRCBro · 2024-05-08T02:23:40Z

se primary pin function is RCINT

i am confused, i test uart2 with CRSF is OK, do you mean, CRSF must work with a full DMA uart, i check hwdef.h only uart1 is full DMA with RX and TX.

HiRCBro · 2024-05-08T12:03:00Z

se primary pin function is RCINT

i am confused, i test uart2 with CRSF is OK, do you mean, CRSF must work with a full DMA uart, i check hwdef.h only uart1 is full DMA with RX and TX.

if uart2 not suitbale for CRSF, we can use UART1, it is full DMA with RX and TX

Hwurzburg · 2024-05-08T12:30:44Z

yes UART1 is the only one that can support CRSF/ELRS...so SBUS->RX2 s RCINT and all single wire RC, and UART1 can handle the two wire protocols

libraries/AP_HAL_ChibiOS/hwdef/LongBowF405WING/defaults.parm

libraries/AP_HAL_ChibiOS/hwdef/LongBowF405WING/Readme.md

libraries/AP_HAL_ChibiOS/hwdef/LongBowF405WING/hwdef.dat

Hwurzburg · 2024-05-09T23:42:44Z

se primary pin function is RCINT

i am confused, i test uart2 with CRSF is OK, do you mean, CRSF must work with a full DMA uart, i check hwdef.h only uart1 is full DMA with RX and TX.

its a matter of RELIABILITY.....CRSF and to a lesser extent ELRS will work without DMA, but not reliably...

HiRCBro · 2024-05-10T01:57:50Z

se primary pin function is RCINT

i am confused, i test uart2 with CRSF is OK, do you mean, CRSF must work with a full DMA uart, i check hwdef.h only uart1 is full DMA with RX and TX.

its a matter of RELIABILITY.....CRSF and to a lesser extent ELRS will work without DMA, but not reliably...

Understood, DMA can reduce CPU load and improve data processing capabilities

HiRCBro · 2024-07-03T01:10:14Z

se primary pin function is RCINT

i am confused, i test uart2 with CRSF is OK, do you mean, CRSF must work with a full DMA uart, i check hwdef.h only uart1 is full DMA with RX and TX.

its a matter of RELIABILITY.....CRSF and to a lesser extent ELRS will work without DMA, but not reliably...

HI
When can this be merged into the master，thankyou.

Hwurzburg · 2024-07-03T01:27:35Z

once the open review comments are addressed, the commits squashed and split into two commits one for Tools and one for hwdef it can be posted for devcall review and probable merge after that call....
if you wish, I can fix the readme recommended changes and squash and split commits for you....let me know

HiRCBro · 2024-07-03T01:29:22Z

once the open review comments are addressed, the commits squashed and split into two commits one for Tools and one for hwdef it can be posted for devcall review and probable merge after that call....
if you wish, I can fix the readme recommended changes and squash and split commits for you....let me know

Please help me complete it， thank you

Hwurzburg

I have applied the changes, rebased, squashed, and library split....since I never got the board (delivered to wrong address I suppose) please retest the firmware on your board...once confirmed I will mark it for devcall (next one is Monday night GMT)

fixed

HiRCBro · 2024-10-15T12:22:04Z

I have applied the changes, rebased, squashed, and library split....since I never got the board (delivered to wrong address I suppose) please retest the firmware on your board...once confirmed I will mark it for devcall (next one is Monday night GMT)

HI
why LongBowF405WING still cant get from https://firmware.ardupilot.org/Plane/stable-4.5.7/

Hwurzburg · 2024-10-15T12:31:14Z

because backports must be requested...I have marked for backport...but I am not sure it will be since 4.6 is about to beta release soon..

HiRCBro · 2024-10-15T12:35:38Z

because backports must be requested...I have marked for backport...but I am not sure it will be since 4.6 is about to beta release soon..

It's been 3 months since I submitted, please help to add it to 4.6?

Hwurzburg · 2024-10-15T12:43:18Z

4.6 will be automatic...its backports that are not...but IF another 4.5 release occurs, it should be added now

HiRCBro · 2024-10-15T12:51:19Z

Ok. thank you

…

magicrub previously requested changes May 7, 2024

View reviewed changes

libraries/AP_HAL_ChibiOS/hwdef/LongBowF405WING/hwdef.dat Outdated Show resolved Hide resolved

libraries/AP_HAL_ChibiOS/hwdef/LongBowF405WING/hwdef.dat Outdated Show resolved Hide resolved

tridge force-pushed the master branch from 7add410 to 46858ee Compare May 7, 2024 19:41

Hwurzburg added the WikiNeeded needs wiki update label May 7, 2024

Hwurzburg self-requested a review May 7, 2024 22:27

Hwurzburg requested changes May 9, 2024

View reviewed changes

Hwurzburg force-pushed the master branch from 18c2b60 to d610bf2 Compare July 4, 2024 01:36

Hwurzburg approved these changes Jul 4, 2024

View reviewed changes

HiRCBro added 2 commits July 6, 2024 09:37

AP_HAL_ChibiOS: longBowF405WING

144392c

Tools: longBowF405WING

536811a

Hwurzburg force-pushed the master branch from 6a0a756 to 536811a Compare July 6, 2024 14:47

Hwurzburg added the DevCallTopic label Jul 7, 2024

CraigElder removed the DevCallTopic label Jul 8, 2024

tridge merged commit 8e28e6a into ArduPilot:master Jul 8, 2024
45 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

AP_HAL_ChibiOS: add hwdef for LongBowF405WING #27009

AP_HAL_ChibiOS: add hwdef for LongBowF405WING #27009

HiRCBro commented May 7, 2024

magicrub left a comment

magicrub commented May 7, 2024

tridge commented May 7, 2024

Hwurzburg commented May 7, 2024

Hwurzburg commented May 7, 2024 •

edited

Loading

HiRCBro commented May 8, 2024

Hwurzburg commented May 8, 2024

HiRCBro commented May 8, 2024

Hwurzburg commented May 8, 2024

HiRCBro commented May 8, 2024

HiRCBro commented May 8, 2024

Hwurzburg commented May 8, 2024

Hwurzburg commented May 9, 2024

HiRCBro commented May 10, 2024

HiRCBro commented Jul 3, 2024

Hwurzburg commented Jul 3, 2024

HiRCBro commented Jul 3, 2024

Hwurzburg left a comment

HiRCBro commented Oct 15, 2024

Hwurzburg commented Oct 15, 2024

HiRCBro commented Oct 15, 2024

Hwurzburg commented Oct 15, 2024

HiRCBro commented Oct 15, 2024 via email

AP_HAL_ChibiOS: add hwdef for LongBowF405WING #27009

AP_HAL_ChibiOS: add hwdef for LongBowF405WING #27009

Conversation

HiRCBro commented May 7, 2024

magicrub left a comment

Choose a reason for hiding this comment

magicrub commented May 7, 2024

tridge commented May 7, 2024

Hwurzburg commented May 7, 2024

Hwurzburg commented May 7, 2024 • edited Loading

HiRCBro commented May 8, 2024

Hwurzburg commented May 8, 2024

HiRCBro commented May 8, 2024

Hwurzburg commented May 8, 2024

HiRCBro commented May 8, 2024

HiRCBro commented May 8, 2024

Hwurzburg commented May 8, 2024

Hwurzburg commented May 9, 2024

HiRCBro commented May 10, 2024

HiRCBro commented Jul 3, 2024

Hwurzburg commented Jul 3, 2024

HiRCBro commented Jul 3, 2024

Hwurzburg left a comment

Choose a reason for hiding this comment

HiRCBro commented Oct 15, 2024

Hwurzburg commented Oct 15, 2024

HiRCBro commented Oct 15, 2024

Hwurzburg commented Oct 15, 2024

HiRCBro commented Oct 15, 2024 via email

Hwurzburg commented May 7, 2024 •

edited

Loading