Initialize sample buffer pointer with nullptr #27024
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to avoid memory corruption on deallocating uninitialized value in `CompassCalibrator.cpp`:384:
```c
if (_sample_buffer != nullptr) {
free(_sample_buffer);
```
peterbarker
reviewed
May 9, 2024
| @@ -79,7 +79,8 @@ extern const AP_HAL::HAL& hal; | |||
| ///////////////////// PUBLIC INTERFACE ///////////////////// | |||
| //////////////////////////////////////////////////////////// | |||
|
|
|||
| CompassCalibrator::CompassCalibrator() | |||
| CompassCalibrator::CompassCalibrator() : | |||
| _sample_buffer(nullptr) | |||
There was a problem hiding this comment.
For this to be a problem we'd have to have allocated this on the stack, essentially: https://ardupilot.org/dev/docs/style-guide.html#implicit-zeroing-of-memory
Do you still see a problem here?
There was a problem hiding this comment.
Yes, in my case it was on the stack. Thank you for the reference. Feel free to close PR then and sorry for the noise.
|
Thanks anyway, @reznikmm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to avoid memory corruption on deallocating uninitialized value in
CompassCalibrator.cpp:384: