Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AC_AttitudeControl_Heli: passthrough_bf_roll_pitch_rate_yaw use quaterion to update attitude target #27052

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

IamPete1
Copy link
Member

This is a update to remove lots of uses of _euler_angle_target this does two things:

  • Switching to use quaternions means we don't need to worry about euler wrap handling
  • This keeps the quaternion attitude target _attitude_target up to date rather than just the euler one _euler_angle_target.

As far as I can tell this should make no difference because neither attitude targets are actually used for anything other than logging while in roll/pitch flybar passthrough.

@MattKear
Copy link
Contributor

I am fairly sure that this won't change the motor outputs, but it would be nice to confirm with the heli motors comparison tool

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants