Add servo 2 and 3 min/max toggle function implementation #27067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmackay9
requested changes
May 15, 2024
There was a problem hiding this comment.
Txs for this.
One small thing is the commit description (not to be confused with the PR description) should be prefixed with the directory name. E.g. "ArduSub". The reason we do this is because it makes backporting much easier if we can see the subsystem affected by each commit.
|
@rmackay9 I've renamed the commit and force-pushed the new one. |
|
thanks @democat3457 , |
Williangalvani
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds missing Servo 2 and 3 min and max toggle functions to the button-handling switch-case.