Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deleted #27086

Closed
wants to merge 0 commits into from
Closed

deleted #27086

wants to merge 0 commits into from

Conversation

burgeruser
Copy link
Contributor

@burgeruser burgeruser commented May 17, 2024

No description provided.

# we can automatically update the IOMCU firmware on boot. The format
# is "ROMFS ROMFS-filename source-filename". Paths are relative to the
# ardupilot root.
ROMFS io_firmware.bin Tools/IO_Firmware/iofirmware_f103_8MHz_lowpolh.bin
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you have an f103 and don't have level shifters then you can also support the iomcu bdshot feature. Please see the Pixhawk6X hwdef for an example

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It requires providing an extra iomcu firmware

@Hwurzburg Hwurzburg added the WikiNeeded needs wiki update label May 17, 2024
@burgeruser burgeruser requested a review from andyp1per May 25, 2024 12:45
@Hwurzburg Hwurzburg self-requested a review May 25, 2024 13:07
Copy link
Collaborator

@andyp1per andyp1per left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to remove the merge commits.

Many of the settings you have in defaults.parm can be moved to the hwdef - that is the common thing to do, but your board

@burgeruser burgeruser requested a review from andyp1per May 29, 2024 01:07
@andyp1per
Copy link
Collaborator

You now need to split the commits across subsystems - use Tools/gittools/git-subsystems-split

@@ -0,0 +1,36 @@
# Now setup the default battery pins driver analog pins and default
SERIAL0_BAUD 460
SERIAL1_BAUD 115
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can do these with define DEFAULT_SERIALx_BAUD y etc in hwdef - please don't define the ones that have the right defaults

SERIAL6_BAUD 460
SERIAL6_PROTOCOL 2

COMPASS_EXTERNAL 1
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should not change these - they should be down to the user.

COMPASS_EXTERN3 1
COMPASS_ORIENT 4

GPS_TYPE 1
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should not change these


GPS_TYPE 1
GPS_TYPE2 1
GPS_RATE_MS 100
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should not change these


BRD_SAFETY_DEFLT 0
FS_THR_ENABLE 0
ARMING_CHECK 10256
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should not change this

@burgeruser burgeruser requested a review from andyp1per May 29, 2024 09:11
Copy link
Collaborator

@andyp1per andyp1per left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also need to remove the merge commit by rebasing

PE15 LED_BLUE OUTPUT HIGH OPENDRAIN GPIO(92)
PC3 LED_AMBER OUTPUT HIGH OPENDRAIN GPIO(94)

PE14 TIM1_CH4 TIM1 PWM(1) GPIO(50) BIDIR
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You only need to put BIDIR on one channel of a pair of 1-2 or 3-4


NTF_DISPLAY_TYPE 1

FRAME_CLASS 1
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think you want to set these - these are specific to copter and this controller could be used on either plane or copter

@burgeruser burgeruser closed this Jun 26, 2024
@burgeruser burgeruser changed the title AP_HAL_ChibiOS/hwdef: PodmanH7 FC board target deleted Jun 26, 2024
@burgeruser burgeruser deleted the new-ChibiOS-Board-podmanH7 branch June 26, 2024 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WikiNeeded needs wiki update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants