-
Notifications
You must be signed in to change notification settings - Fork 17.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HAL_QURT: revived QURT HAL #27091
HAL_QURT: revived QURT HAL #27091
Conversation
da0bc2b
to
e40fe93
Compare
af10060
to
6f6239b
Compare
@@ -0,0 +1,80 @@ | |||
# parameters for the autonomy dev kit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MP's parameter loader apparently can't see files below the "Frame_params" directory so perhaps we should move this up and add a prefix. E.g. "ModalAI_AutonomyDevKit.parm"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as discussed on the call, once merged I will do a MissionPlanner PR to support this directory, like I did for quadplanes
We should add pages to the developer wiki to clarify how to setup the build environment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this PR seems to rely elmost entirely on POSIX pthread/s , and I wonder if it shouldn't be called AP_HAL_PTHREADS or AP_HAL_POSIX, or have an intermediate layer for the pthreads and/or posix related stuff... especially since other hal/s like Linux and ESP32 both have posix and pthreads support.
eg esp32 pthreads support here: https://docs.espressif.com/projects/esp-idf/en/stable/esp32/api-reference/system/pthread.html
That's more of a suggestion for the future tho, not a stopper for this PR, which clearly works well-enough to merge.
5a2fce5
to
e982bd0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM apart from the very minor things raised.
fixes replay build with posix compat changes
based around new SDK for ModalAI Voxl2 vehicles
some features disabled
This is a revival of the old QURT HAL for the new ModalAI boards, testing on a starling dev copter
this builds on #27504
Issues:
Testing: