Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GCS_MAVLink: Notify access from an invalid system ID #27096

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+1 −0
Open

GCS_MAVLink: Notify access from an invalid system ID #27096

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions libraries/GCS_MAVLink/GCS_Common.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6864,6 +6864,7 @@ void GCS_MAVLINK::manual_override(RC_Channel *c, int16_t value_in, const uint16_
void GCS_MAVLINK::handle_manual_control(const mavlink_message_t &msg)
{
if (msg.sysid != sysid_my_gcs()) {
GCS_SEND_TEXT(MAV_SEVERITY_WARNING, "Ignore sysid %u", msg.sysid);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. this is only once place a warning might need to be sent (make a send_sysid_ignored() method?)
  2. this message would need to be rate-limited as these messages can come in fast, and you will flood people with messages.

return; // only accept control from our gcs
}

Expand Down
Loading