Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

autotest: neaten Copter Loiter test #27113

Merged
merged 1 commit into from
May 21, 2024

Conversation

peterbarker
Copy link
Contributor

... the harness takes care of the cleanup in case of error

Copy link
Contributor

@rmackay9 rmackay9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'd just like to check that you've tested the failure case to confirm the failure is reported correctly to the user/caller.

@peterbarker
Copy link
Contributor Author

LGTM. I'd just like to check that you've tested the failure case to confirm the failure is reported correctly to the user/caller.

The code which catches this now is here: https://github.com/ardupilot/ardupilot/blob/master/Tools/autotest/vehicle_test_suite.py#L8458

... that code is there to make the changes I'm making in this PR (and several very similar PRs) possible.

@peterbarker peterbarker merged commit 37886b3 into ArduPilot:master May 21, 2024
42 checks passed
@peterbarker peterbarker deleted the pr/test-neaten branch May 22, 2024 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants