-
Notifications
You must be signed in to change notification settings - Fork 17.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
autotest: Add catapult test #27125
autotest: Add catapult test #27125
Conversation
The way to call the test is ./Tools/autotest/autotest.py --no-clean --frame plane-catapult --speedup 10 build.Plane test.Plane.CatapultTakeoff This PR is WIP because it's premature and failing. There are two issues with it:
Even more weirdly, autotest things the airspeed has risen, when the logs shows it hasn't. AT-0004.1: airspeed=0.40 (want between 21.0 and 100)
AT-0004.1: AP: Triggered AUTO. GPS speed = 0.8
AT-0004.2: airspeed=13.59 (want between 21.0 and 100)
AT-0004.2: AP: SIM Hit ground at 3.284683 m/s
AT-0004.3: airspeed=27.58 (got between 21.0 and 100) (maintain=0.6/5.0)
AT-0004.3: AP: SIM Hit ground at 4.907945 m/s
AT-0004.3: AP: Holding course 35398 at 28.8m/s (-0.0)
AT-0004.4: airspeed=26.24 (got between 21.0 and 100) (maintain=1.7/5.0)
AT-0004.4: AP: SIM Hit ground at 4.911546 m/s
AT-0004.5: airspeed=25.58 (got between 21.0 and 100) (maintain=2.8/5.0)
AT-0004.6: AP: SIM Hit ground at 3.960280 m/s
AT-0004.6: airspeed=25.28 (got between 21.0 and 100) (maintain=3.8/5.0)
AT-0004.7: AP: SIM Hit ground at 3.963535 m/s
AT-0004.8: airspeed=25.92 (got between 21.0 and 100) (maintain=4.9/5.0)
AT-0004.8: AP: SIM Hit ground at 3.964641 m/s
AT-0004.8: Attained airspeed=25.871821010813992
There's a slight chance I'm looking at the wrong .bin. I inspected |
6485a2d
to
1890365
Compare
@peterbarker thanks for the suggestions. I've implemented it and it's running now. Question: Remark: If you agree, we can consider this PR done and I can open an Issue ticket. |
self.wait_ready_to_arm() | ||
self.arm_vehicle() | ||
|
||
# Throw the catapult. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# Throw the catapult. | |
self.progress("Throw the catapult") |
Many times when I've put a comment like this in I've found it useful to put it in as a progress text instead. Just a suggestion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! For now it's pretty evident (perhaps even more useful) by plotting RCOU[7]. But I'll keep that in mind.
Whatever is most convenient, really. Crafting your own mission gives you exactly what you want with no complication, but takes longer. Note you can also load a "generic mission", a relatively new concept in the suite I'm still playing around with. e.g.
There's something else you might be able to get away with, depending. Which is to just use "takeoff mode" to the appropriate altitude (it uses TECS). This may or may not reproduce, we do a few little interesting things in takeoff mode which might cause the problem to not reproduce. You could possibly do something like this:
Yes - and you should use that ticket number in the |
1890365
to
471e0e2
Compare
I have updated the PR to switch from a check for receding throttle to a check for correct airspeed regulation. |
c707e42
to
3237e16
Compare
An autotest for a catapult launch has been added for Plane. Larger maximum pitch limit has been allowed, to demonstrate pitch behaviour. An auxiliary `set_servo` method has been added to `vehicle_test_suite.py`. For now, it is placed as known failing test.
3237e16
to
6739134
Compare
closing in favor of the test code in #27174 |
An autotest for a catapult launch has been added for Plane.
An auxiliary
set_servo
method has been added tovehicle_test_suite.py
.