Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lua binding to set airspeed for a fixed wing Plane #27223

Closed
wants to merge 3 commits into from
Closed

Lua binding to set airspeed for a fixed wing Plane #27223

wants to merge 3 commits into from

Conversation

timtuxworth
Copy link
Contributor

@timtuxworth timtuxworth commented Jun 2, 2024 •
edited
Loading

For a method to allow plane airspeed to be set for a fixed wing. Currently this will only work in Guided and Auto mode.

@timtuxworth
Copy link
Contributor Author

I thought it might be a good idea to split this out of my scripting PR's so the AP/c++ code can get potentially merged without getting caught up in discussions about the Lua code. I'm thinking others might also find this useful. @IamPete1 could I ask you to take a look?

IamPete1
IamPete1 reviewed Jun 2, 2024
View reviewed changes
ArduPlane/ArduPlane.cpp Outdated Show resolved Hide resolved
IamPete1
IamPete1 reviewed Jun 2, 2024
View reviewed changes
ArduPlane/ArduPlane.cpp Outdated Show resolved Hide resolved
@timtuxworth timtuxworth force-pushed the plane_follow_bindings branch from 1bd4ad8 to e20a050 Compare June 3, 2024 16:38
@timtuxworth
Copy link
Contributor Author

Do you have any thoughts @Hwurzburg ?

IamPete1
IamPete1 previously requested changes Jun 10, 2024
View reviewed changes
libraries/AP_Scripting/docs/docs.lua Outdated Show resolved Hide resolved
libraries/AP_Scripting/docs/docs.lua Outdated Show resolved Hide resolved
libraries/AP_Scripting/docs/docs.lua Outdated Show resolved Hide resolved
libraries/AP_Scripting/docs/docs.lua Outdated Show resolved Hide resolved
ArduPlane/ArduPlane.cpp Outdated Show resolved Hide resolved
@timtuxworth timtuxworth force-pushed the plane_follow_bindings branch from 1c2d820 to 5898bc9 Compare June 10, 2024 20:56
@IamPete1 IamPete1 dismissed their stale review June 11, 2024 00:11

Fixed.

@timtuxworth timtuxworth force-pushed the plane_follow_bindings branch from 5898bc9 to 99e9172 Compare June 14, 2024 18:53
@timtuxworth timtuxworth force-pushed the plane_follow_bindings branch 2 times, most recently from 0ff3deb to 6b58e90 Compare June 16, 2024 17:22
@Hwurzburg Hwurzburg requested a review from IamPete1 June 17, 2024 20:49
rmackay9
rmackay9 reviewed Jun 18, 2024
View reviewed changes
ArduPlane/ArduPlane.cpp Outdated Show resolved Hide resolved
@timtuxworth timtuxworth force-pushed the plane_follow_bindings branch from 6b58e90 to 13f308f Compare June 18, 2024 00:44
@timtuxworth
Copy link
Contributor Author

This has been tested on a real quadplane by a partner.

@timtuxworth
Copy link
Contributor Author

Based on the dev call 2024-06-17 could you take a look at this please @tridge ? (no rush)

tridge
tridge requested changes Jun 23, 2024
View reviewed changes
Copy link
Contributor

@tridge tridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@peterbarker I think this PR is a great example of where we need generic access to MAV_CMD_xxx from lua. As we have discussed I think we should just bind it to the first mavlink GCS instance instead of creating a dedicated instance (at least for now), but open to discussion
If we did that then all the MAV_CMD_GUIDED_xxx functionality would be available at very low cost, along with all the other fns

ArduPlane/ArduPlane.cpp Outdated Show resolved Hide resolved
ArduPlane/ArduPlane.cpp Outdated Show resolved Hide resolved
@tridge tridge mentioned this pull request Jun 23, 2024
Merged
@timtuxworth timtuxworth force-pushed the plane_follow_bindings branch 2 times, most recently from 3c51322 to 9e18667 Compare June 24, 2024 01:26
@timtuxworth timtuxworth force-pushed the plane_follow_bindings branch from 9e18667 to 6a751dd Compare June 24, 2024 01:28
@timtuxworth timtuxworth changed the title Plane follow bindings Lua binding to set airspeed for a fixed wing Plane Jun 24, 2024
@timtuxworth
Copy link
Contributor Author

Tridge's MavLink Command_int Lua interface PR is at least as good as this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterbarker peterbarker peterbarker left review comments

@rmackay9 rmackay9 rmackay9 left review comments

@tridge tridge tridge requested changes

@IamPete1 IamPete1 Awaiting requested review from IamPete1

Assignees
No one assigned
Labels
Plane Scripting
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@timtuxworth @tridge @rmackay9 @peterbarker @IamPete1 @CraigElder