Added AP_EFI_Serial_FH driver, changed AP_EFI and config to accommodate new driver #27313
Conversation
|
|
||
| #if AP_EFI_SERIAL_FH_ENABLED | ||
|
|
||
| #include <AP_HAL/AP_HAL.h> |
There was a problem hiding this comment.
I don't think anything's being used from this header.
| extern const AP_HAL::HAL &hal; | ||
|
|
There was a problem hiding this comment.
| extern const AP_HAL::HAL &hal; | |
| // Indicate that temperature and fuel pressure are supported | ||
| internal_state.fuel_pressure_status = Fuel_Pressure_Status::OK; | ||
| internal_state.temperature_status = Temperature_Status::OK; | ||
|
|
||
| // FlyHenry ECU reports EGT | ||
| internal_state.cylinder_status.exhaust_gas_temperature = 0; | ||
| internal_state.cylinder_status.exhaust_gas_temperature2 = 0; | ||
|
|
||
| } |
There was a problem hiding this comment.
Initialise these in the header files where the variable is declared.
Do not initialise variables to zero unless they're on the stack (https://ardupilot.org/dev/docs/style-guide.html#implicit-zeroing-of-memory)
| } | ||
|
|
||
|
|
||
| bool AP_EFI_Serial_FH::process(uint32_t const now) { |
There was a problem hiding this comment.
| bool AP_EFI_Serial_FH::process(uint32_t const now) { | |
| bool AP_EFI_Serial_FH::process(uint32_t const now) | |
| { |
You can use astyle to conform to the code style guides.
| uint8_t sum8(uint8_t *buf, size_t len) { | ||
| uint8_t sum = 0; | ||
| for (size_t i = 0; i < len; i++) sum += buf[i]; | ||
| return sum; | ||
| } | ||
|
|
There was a problem hiding this comment.
| uint8_t sum8(uint8_t *buf, size_t len) { | |
| uint8_t sum = 0; | |
| for (size_t i = 0; i < len; i++) sum += buf[i]; | |
| return sum; | |
| } | |
available as crc_sum_of_bytes
| float convertFuelConsumption(float fuelConsumption_lph) { | ||
| const int // Conversion factors | ||
| litersToCubicCentimeters = 1000,// 1 liter = 1000 cm³ | ||
| hoursToMinutes = 60; // 1 hour = 60 minutes | ||
|
|
||
| float // Convert l/h to cm³/m | ||
| fuelConsumption_cmh = fuelConsumption_lph * litersToCubicCentimeters,// l/h to cm³/h | ||
| fuelConsumption_cmm = fuelConsumption_cmh / hoursToMinutes; // cm³/h to cm³/m | ||
|
|
||
| return fuelConsumption_cmm; | ||
| } |
There was a problem hiding this comment.
Move this to the cpp file
| uint8_t pkt[50]; | ||
| }; | ||
| size_t ind; | ||
| uint32_t last_recv; // ms |
There was a problem hiding this comment.
| uint32_t last_recv; // ms |
use last_recv_ms
| @@ -32,6 +32,10 @@ | |||
| #define AP_EFI_SCRIPTING_ENABLED (AP_EFI_BACKEND_DEFAULT_ENABLED && AP_SCRIPTING_ENABLED) | |||
| #endif | |||
|
|
|||
| #ifndef AP_EFI_SERIAL_FH_ENABLED | |||
| #define AP_EFI_SERIAL_FH_ENABLED AP_EFI_BACKEND_DEFAULT_ENABLED | |||
There was a problem hiding this comment.
| #define AP_EFI_SERIAL_FH_ENABLED AP_EFI_BACKEND_DEFAULT_ENABLED | |
| #define AP_EFI_SERIAL_FH_ENABLED AP_EFI_BACKEND_DEFAULT_ENABLED && AP_ICENGINE_ENABLED |
| @@ -73,7 +73,7 @@ class AP_ICEngine { | |||
|
|
|||
| static AP_ICEngine *get_singleton() { return _singleton; } | |||
|
|
|||
| private: | |||
| //!!private: | |||
There was a problem hiding this comment.
Yeah, no. This isn't acceptable.
If you think you can make a reasonable case for exposing the state machine state, make an accessor for it. Check other available interface lements first....
Co-authored-by: Peter Barker <[email protected]>
|
Ping @gonzoveliki this is awaiting rework. |
|
@peterbarker aren't we doing LUA drivers instead of C++ drivers now for EFI? |
Dedicated serial driver for getting telemetry from EFI Fly Henry.
https://www.[flyhenry.cz/images/navody-pdf/engine-management/Engine_Management_Manual_260_Fly_henry1.pdf
It is still in development, I have to map and scale all readings thoroughly. It's not breaking anything... tested with CubeOrange+