Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copter: Remove Payload release on thrust loss detection #27339

Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions ArduCopter/crash_check.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,12 @@ void Copter::crash_check()
}
}

// check for loss of thrust and trigger thrust boost in motors library
// thrust_loss_check - returns true when the aircraft detects for 1 second that it is:
// above 90% thrust,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// above 90% thrust,
// above 90% demanded thrust or high thrust saturation,

// less than 15 degrees lean angle target,
// less than 30 degrees of attitude error,
// is descending.
// This check provides a warning that the aircraft is near it's maximum thrust limits and is used trigger thrust boost algorithm in the motors library
void Copter::thrust_loss_check()
{
static uint16_t thrust_loss_counter; // number of iterations vehicle may have been crashed
Expand Down Expand Up @@ -169,12 +174,6 @@ void Copter::thrust_loss_check()
// enable thrust loss handling
motors->set_thrust_boost(true);
// the motors library disables this when it is no longer needed to achieve the commanded output

#if AP_GRIPPER_ENABLED
if (copter.option_is_enabled(FlightOption::RELEASE_GRIPPER_ON_THRUST_LOSS)) {
gripper.release();
}
#endif
Comment on lines -172 to -177
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't just remove this. The would need to be a arming check if the option is set and the feature is gone.

}
}

Expand Down
Loading