-
Notifications
You must be signed in to change notification settings - Fork 17.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Copter: Remove Payload release on thrust loss detection #27339
Closed
lthall
wants to merge
2
commits into
ArduPilot:master
from
lthall:20240620_RandomPaylaodReleaseFeatureRemoval
Closed
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -96,7 +96,12 @@ void Copter::crash_check() | |
} | ||
} | ||
|
||
// check for loss of thrust and trigger thrust boost in motors library | ||
// thrust_loss_check - returns true when the aircraft detects for 1 second that it is: | ||
// above 90% thrust, | ||
// less than 15 degrees lean angle target, | ||
// less than 30 degrees of attitude error, | ||
// is descending. | ||
// This check provides a warning that the aircraft is near it's maximum thrust limits and is used trigger thrust boost algorithm in the motors library | ||
void Copter::thrust_loss_check() | ||
{ | ||
static uint16_t thrust_loss_counter; // number of iterations vehicle may have been crashed | ||
|
@@ -169,12 +174,6 @@ void Copter::thrust_loss_check() | |
// enable thrust loss handling | ||
motors->set_thrust_boost(true); | ||
// the motors library disables this when it is no longer needed to achieve the commanded output | ||
|
||
#if AP_GRIPPER_ENABLED | ||
if (copter.option_is_enabled(FlightOption::RELEASE_GRIPPER_ON_THRUST_LOSS)) { | ||
gripper.release(); | ||
} | ||
#endif | ||
Comment on lines
-172
to
-177
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We can't just remove this. The would need to be a arming check if the option is set and the feature is gone. |
||
} | ||
} | ||
|
||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.