Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detune to stop ground oscillation #27341

Merged
merged 2 commits into from
Jul 24, 2024

Conversation

lthall
Copy link
Contributor

@lthall lthall commented Jun 20, 2024

This pr provides the ability to reduce the gains of roll, pitch, and yaw to remove ground oscillation while landed. Each axis has a gain reduction variable that is set when the aircraft is landed. The gain returns to normal in 2 x ATC_INPUT_TC.

This is a common problem on aircraft with flexible landing gear. It is often seen as a yaw oscillation during spool up on more solidly built aircraft also.

@Hwurzburg Hwurzburg added the WikiNeeded needs wiki update label Jun 24, 2024
@rmackay9
Copy link
Contributor

@lthall I'm sure this will be popular. Do we need to have both Roll and Pitch parameters? I wonder if we can imagine a frame where we'd want them to be different.

@bnsgeyer
Copy link
Contributor

@lthall I'm sure this will be popular. Do we need to have both Roll and Pitch parameters? I wonder if we can imagine a frame where we'd want them to be different.

I think for heli there could be significantly different gains between pitch and roll. But I don't know if the same backoff factor could work for both axes.

@lthall
Copy link
Contributor Author

lthall commented Jun 28, 2024

I considered this but I believe it would be a mistake to not separate them. We don't want to compromise control authority unnecessarily. There are numerous aircraft that have significantly different ground interaction modes between all three axis.

@lthall lthall requested review from andyp1per, MichelleRos, bnsgeyer, rmackay9 and IamPete1 and removed request for MichelleRos July 21, 2024 03:20
@lthall lthall force-pushed the 20240423_GroundOccilation branch from 20665d0 to d855661 Compare July 21, 2024 03:23
Copy link
Member

@IamPete1 IamPete1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just to confirm, it does should up in the ATSC log message?

@lthall
Copy link
Contributor Author

lthall commented Jul 21, 2024

@IamPete1 Sorry mate, I didn't understand what you were asking.

@IamPete1
Copy link
Member

IamPete1 commented Jul 22, 2024

@IamPete1 Sorry mate, I didn't understand what you were asking.

The ATSC message contains the used values of the angle P scale and the rate PD scale if not all ones. The logging should "just work" with your changes, but it would be worth double checking just so we can track what is going on. You should see them slew up and down, Once they get to all ones the log should stop.

@lthall lthall force-pushed the 20240423_GroundOccilation branch from d855661 to 01ab103 Compare July 22, 2024 03:34
@lthall
Copy link
Contributor Author

lthall commented Jul 22, 2024

image

@lthall lthall force-pushed the 20240423_GroundOccilation branch from 01ab103 to 4f9e599 Compare July 22, 2024 03:38
@lthall lthall force-pushed the 20240423_GroundOccilation branch from ad0d225 to 26a2bbe Compare July 23, 2024 07:21
@lthall lthall force-pushed the 20240423_GroundOccilation branch from 26a2bbe to 18f05b2 Compare July 23, 2024 07:32
Copy link
Contributor

@rmackay9 rmackay9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the changes

@peterbarker peterbarker merged commit 1012be9 into ArduPilot:master Jul 24, 2024
93 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants