-
Notifications
You must be signed in to change notification settings - Fork 18.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Detune to stop ground oscillation #27341
Detune to stop ground oscillation #27341
Conversation
@lthall I'm sure this will be popular. Do we need to have both Roll and Pitch parameters? I wonder if we can imagine a frame where we'd want them to be different. |
I think for heli there could be significantly different gains between pitch and roll. But I don't know if the same backoff factor could work for both axes. |
I considered this but I believe it would be a mistake to not separate them. We don't want to compromise control authority unnecessarily. There are numerous aircraft that have significantly different ground interaction modes between all three axis. |
20665d0
to
d855661
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Just to confirm, it does should up in the ATSC
log message?
@IamPete1 Sorry mate, I didn't understand what you were asking. |
The |
d855661
to
01ab103
Compare
01ab103
to
4f9e599
Compare
ad0d225
to
26a2bbe
Compare
26a2bbe
to
18f05b2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the changes
This pr provides the ability to reduce the gains of roll, pitch, and yaw to remove ground oscillation while landed. Each axis has a gain reduction variable that is set when the aircraft is landed. The gain returns to normal in 2 x ATC_INPUT_TC.
This is a common problem on aircraft with flexible landing gear. It is often seen as a yaw oscillation during spool up on more solidly built aircraft also.