Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AP_BattMonitor: Sum, ESC: all selected items must be found to not be missing #27359

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

IamPete1
Copy link
Member

Currently both the sum and ESC backends will hide a failure because they take a average. So if one item is lost the voltage stays the same and no fail-safe is tripped. This will now mark the monitor unhealthy if any item is missing. With #27358 this gives a clear warning to the pilot.

tridge
tridge previously requested changes Jun 25, 2024
Copy link
Contributor

@tridge tridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to think about a case such as an octo-quad copter, using ESC telem for voltage, with battery failsafes enabled, and an ESC blows up, so we lose telemettry
the ESC based voltage monitor would now be unhealthy, does this change behaviour? do we lose the ability to do failsafes?
looks like unhealthy prevents current accumulation for battery percentage failsafe

@IamPete1 IamPete1 dismissed tridge’s stale review July 2, 2024 16:21

Added a new "missing" method so a backend can be both healthy and missing.

@IamPete1 IamPete1 requested a review from tridge July 2, 2024 16:22
@IamPete1 IamPete1 changed the title AP_BattMonitor: Sum, ESC: all selected items must be found for health. AP_BattMonitor: Sum, ESC: all selected items must be found to not be missing Jul 2, 2024
@tridge
Copy link
Contributor

tridge commented Jul 3, 2024

so what happens when an esc fails on an octo using ESC telem for battery monitoring? single statustext? continual messages?

@tridge tridge removed the DevCallEU label Jul 3, 2024
@IamPete1
Copy link
Member Author

IamPete1 commented Jul 3, 2024

so what happens when an esc fails on an octo using ESC telem for battery monitoring? single statustext? continual messages?

You hit the new missing battery failsafe, no action but same reporting behavior as the existing failsafes. Single message and beeper going. The low voltage/capacity failfafes will still trigger as before.

@IamPete1
Copy link
Member Author

IamPete1 commented Jul 8, 2024

This costs about 200B on 1M boards and 100B on periph. We could define out the new method on periph for zero flash cost.

@tridge
Copy link
Contributor

tridge commented Jul 9, 2024

i'll do the test for octo-quad esc failure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants