-
Notifications
You must be signed in to change notification settings - Fork 17.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AP_BattMonitor: Sum, ESC: all selected items must be found to not be missing #27359
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need to think about a case such as an octo-quad copter, using ESC telem for voltage, with battery failsafes enabled, and an ESC blows up, so we lose telemettry
the ESC based voltage monitor would now be unhealthy, does this change behaviour? do we lose the ability to do failsafes?
looks like unhealthy prevents current accumulation for battery percentage failsafe
…ethod and arming check
Added a new "missing" method so a backend can be both healthy and missing.
so what happens when an esc fails on an octo using ESC telem for battery monitoring? single statustext? continual messages? |
You hit the new missing battery failsafe, no action but same reporting behavior as the existing failsafes. Single message and beeper going. The low voltage/capacity failfafes will still trigger as before. |
This costs about 200B on 1M boards and 100B on periph. We could define out the new method on periph for zero flash cost. |
i'll do the test for octo-quad esc failure |
Currently both the sum and ESC backends will hide a failure because they take a average. So if one item is lost the voltage stays the same and no fail-safe is tripped. This will now mark the monitor unhealthy if any item is missing. With #27358 this gives a clear warning to the pilot.