-
Notifications
You must be signed in to change notification settings - Fork 17.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rename ins get_primary_accel to get_default_accel #27383
Closed
peterbarker
wants to merge
7
commits into
ArduPilot:master
from
peterbarker:pr/rename-primary-to-get-default
Closed
rename ins get_primary_accel to get_default_accel #27383
peterbarker
wants to merge
7
commits into
ArduPilot:master
from
peterbarker:pr/rename-primary-to-get-default
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterbarker
force-pushed
the
pr/rename-primary-to-get-default
branch
from
June 25, 2024 04:03
1e89189
to
1fe0fb0
Compare
|
peterbarker
force-pushed
the
pr/rename-primary-to-get-default
branch
from
June 25, 2024 04:04
1fe0fb0
to
5e2a2d6
Compare
andyp1per
requested changes
Jun 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I want get_first_usable_accel() I think its clearer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We agreed on DevCall to rename to
get_first_usable_accel
.get_default_accel
might be better in that a user could have a parameter specifying their primary accelerometer to be usedI have a branch which renames to
get_first_usable_accel
, too...