Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename ins get_primary_accel to get_default_accel #27383

Conversation

peterbarker
Copy link
Contributor

@peterbarker peterbarker commented Jun 25, 2024

We agreed on DevCall to rename to get_first_usable_accel.

get_default_accel might be better in that a user could have a parameter specifying their primary accelerometer to be used

I have a branch which renames to get_first_usable_accel, too...

@peterbarker
Copy link
Contributor Author

Board                    AP_Periph  blimp  bootloader  copter  heli  iofirmware  plane  rover  sub
CubeOrange-periph-heavy  *                                                                     
Durandal                            *      *           *       *                 *      *      *
Hitec-Airspeed           *                                                                     
KakuteH7-bdshot                     *      *           *       *                 *      *      *
MatekF405                           *      *           *       *                 *      *      *
Pixhawk1-1M-bdshot                  *                  *       *                 *      *      *
f103-QiotekPeriph        *                                                                     
f303-Universal           *                                                                     
iomcu                                                                *                         
revo-mini                           *      *           *       *                 *      *      *
skyviper-v2450                                         *                                       

@peterbarker peterbarker force-pushed the pr/rename-primary-to-get-default branch from 1fe0fb0 to 5e2a2d6 Compare June 25, 2024 04:04
Copy link
Collaborator

@andyp1per andyp1per left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want get_first_usable_accel() I think its clearer

@tridge tridge closed this Jun 26, 2024
@peterbarker peterbarker deleted the pr/rename-primary-to-get-default branch June 26, 2024 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants