AP_Notify: flash green lights based off location not GPS #27385
Conversation
Your Copter in stabilize mode can flash rapid-green indicating a good DGPS lock or better, and yet your vehicle still doesn't have a good idea of where it is. That means that your vehicle may end up RTL'ing onto a point somewhere along your flight path, when you were given an all-green indication by teh vehicle before you armed in stabilize. Past this PR, we require the same GPS as before, but in addition we must have been happy enough with our location to set the navigation origin, *and* currently be able to get a location. A user will receive slow-flashing blue lights if they can't currently get a location, or the navigation origin isn't set, even if they've got a "good" fix. We also require a good location to get a solid green light - you will get a solid blue light if you can't get a location or don't have a navigation origin, even if you have a good GPS lock
peterbarker
force-pushed
the
pr/ahrs-not-gps-for-lights
branch
from
5549fce to
48706f4
Compare
|
I really want this as a pre-arm option as well. I am forever waiting for status in loiter before switching to acro and flying because I want to make sure that RTL will work well. |
|
Thank You Peter Barker. |
You're welcome ;-) |
Is there somewhere we should post about this to head those questions off? |
|
Hi @peterbarker, This wiki page should probably be updated https://ardupilot.org/copter/docs/common-leds-pixhawk.html I've added an item to my 4.6.0 release warnings text document so when it comes time to do the beta testing and final release I'll add a warning to the blog post and release announcements |
|
😃 so Happy
Randy Mackay ***@***.***> 於 2024年6月26日 週三 上午10:25 寫道：
… Hi @peterbarker <https://github.com/peterbarker>,
This wiki page should probably be updated
https://ardupilot.org/copter/docs/common-leds-pixhawk.html
I've added an item to my 4.6.0 release warnings text document so when it
comes time to do the beta testing and final release I'll add a warning to
the blog post and release announcements
—
Reply to this email directly, view it on GitHub
<#27385 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABNS3FKMXOUE2PH2NMWSAJ3ZJIQ7ZAVCNFSM6AAAAABJ3COEFWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOJQGQYTMNZWGE>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
|
@peterbarker this seems incomplete...what about systems using LEDA and LEDB??this only affects RGB notify leds |
Your Copter in stabilize mode can flash rapid-green indicating a good DGPS lock or better, and yet your vehicle still doesn't have a good idea of where it is.
That means that your vehicle may end up RTL'ing onto a point somewhere along your flight path, when you were given an all-green indication by teh vehicle before you armed in stabilize.
Past this PR, we require the same GPS as before, but in addition we must have been happy enough with our location to set the navigation origin, and currently be able to get a location.
A user will receive slow-flashing blue lights if they can't currently get a location, or the navigation origin isn't set, even if they've got a "good" fix.
We also require a good location to get a solid green light - you will get a solid blue light if you can't get a location and have a navigation origin, even if you have a good GPS lock
Closes #27320
Tested in SITL using
--rgbled