Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use 64 bit time for PPS interrupt in Ublox driver #27387

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

bugobliterator
Copy link
Member

If using 32 bit time for PPS interrupt the corrected time can be set incorrectly after 2^32 microsecond, and cause ublox redetection code to run again and result in Ublox module to drop out after around 1hour and 12 minutes.

@bugobliterator bugobliterator requested a review from tridge June 25, 2024 07:18
Copy link
Contributor

@tridge tridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer the muxh simpler fix of:

    _last_pps_time_us = AP_HAL::micros64();

in AP_GPS_UBLOX::pps_interrupt, with a comment as to why we can't use the passed in timestamp_us

@tridge tridge merged commit 178cf7c into ArduPilot:master Jun 26, 2024
92 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants