Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AP_GPS: hdop and vdop are unitless #27400

Merged
merged 1 commit into from
Jul 14, 2024

Conversation

Williangalvani
Copy link
Contributor

@Williangalvani Williangalvani commented Jun 27, 2024

@tpwrules
Copy link
Contributor

They don’t have a physical unit, but they are scaled by 100. I.e. if the field has a value of 157, then a GCS would display an hdop of 1.57.

The comment should explain this scaling.

@Williangalvani
Copy link
Contributor Author

They don’t have a physical unit, but they are scaled by 100. I.e. if the field has a value of 157, then a GCS would display an hdop of 1.57.

The comment should explain this scaling.

Hah, I had looked at the code for UBX and it sets the hdop directly. but UBX itself has it scaled:
image
I'll update the comment

@peterbarker
Copy link
Contributor

They don’t have a physical unit, but they are scaled by 100. I.e. if the field has a value of 157, then a GCS would display an hdop of 1.57.

The comment should explain this scaling.

Not sure how "GCS" enters into the equation here. These variables are internal to ArduPilot; you have to go via the mavlink layer to get data to the GCS (typically).

It looks like the descriptions on the mavlink messages could be improved in a manner similar to this PR, 'though!

      <field type="uint16_t" name="eph">GPS HDOP horizontal dilution of position (unitless). If unknown, set to: UINT16_MAX</field>

@peterbarker peterbarker merged commit ef9763f into ArduPilot:master Jul 14, 2024
92 checks passed
@Williangalvani Williangalvani deleted the unitless_hdop_vdop branch July 14, 2024 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants