Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rover: fix failsafe reason reported #27432

Closed
wants to merge 2 commits into from

Conversation

khancyr
Copy link
Contributor

@khancyr khancyr commented Jul 1, 2024

follow #27431 (review),

fix failsafe reason. Issue comes from PR #25066 .

@khancyr khancyr force-pushed the feature/fix-modeReason2 branch from 6e4bd29 to fb82696 Compare July 1, 2024 16:37
@rmackay9
Copy link
Contributor

rmackay9 commented Jul 2, 2024

sorry, I tried out the rebase button for the first time (for me) and perhaps selected the wrong option.

In any case, I think the other PR was included to include this PR's fixes so we can probably just close this one.

@khancyr
Copy link
Contributor Author

khancyr commented Jul 2, 2024

ho yes, Willian update his PR after my review, so I didn't see he update with the whole fix. Closing this then

@khancyr khancyr closed this Jul 2, 2024
@khancyr khancyr deleted the feature/fix-modeReason2 branch July 2, 2024 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants