Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AP_NavEKF3: remove storedRange member variable if rangefinder measure… #27448

Merged

Conversation

peterbarker
Copy link
Contributor

…ments disabled

Board               blimp  bootloader  copter  heli  iofirmware  plane  rover  sub
Durandal            -32    *           -16     -16               -24    -24    -16
KakuteH7-bdshot     -104   *           -112    -104              -104   -112   -112
MatekF405           -72    *           -72     -72               -64    -16    -64
Pixhawk1-1M-bdshot  -96                -96     -88               -88    -24    -88
iomcu                                                *                         
revo-mini           -72    *           -72     -64               -64    -24    -64

We do need to come back and clean up these defines. We should have one define for "do we store rangefinder measurements?" (which we have), but we should also have a "can we directly fuse rangefinder measurements?" and "can we provide rangefinder measurements for optical flow fusion?"

At the moment we essentially only have one define controlling all of these things (AP_RANGEFINDER_ENABLED)

Copy link
Contributor

@khancyr khancyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

EK3_FEATURE_RANGEFINDER_MEASUREMENTS vs AP_RANGEFINDER_ENABLED is confusing even if they are the same for now

@peterbarker peterbarker merged commit ce48932 into ArduPilot:master Jul 4, 2024
92 checks passed
@peterbarker peterbarker deleted the pr/no-rangefinder-no-storedrange branch July 4, 2024 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants