GCS_MAVLink: correct a debugging message #27480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Probably changed from a pointer to reference at some point and forgot to update a normally disabled block
khancyr
approved these changes
Jul 8, 2024
There was a problem hiding this comment.
LGTM
Setting ROUTING_DEBUG to 1 make a compile error :
[ 692/1325] Compiling libraries/GCS_MAVLink/MAVLink_routing.cpp
../../libraries/GCS_MAVLink/MAVLink_routing.cpp: In member function ‘bool MAVLink_routing::check_and_forward(GCS_MAVLINK&, const mavlink_message_t&)’:
../../libraries/GCS_MAVLink/MAVLink_routing.cpp:202:47: error: base operand of ‘->’ has non-pointer type ‘GCS_MAVLINK’
202 | (unsigned)in_link->get_chan(),
| ^~
compilation terminated due to -Wfatal-errors.
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Probably changed from a pointer to reference at some point and forgot to update a normally disabled block