Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove debug shell #27506

Merged
merged 6 commits into from
Jul 10, 2024
Merged

Remove debug shell #27506

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
93b41dd
AP_HAL_ChibiOS: removed run_debug_shell
tridge Jul 5, 2024
504b9fc
AP_HAL_Empty: removed run_debug_shell
tridge Jul 5, 2024
982ff3d
AP_HAL: removed run_debug_shell
tridge Jul 5, 2024
0d7b8e5
AP_HAL_Linux: removed run_debug_shell
tridge Jul 5, 2024
2fd823f
AP_HAL_SITL: removed run_debug_shell
tridge Jul 5, 2024
d12dd01
HAL_ESP32: removed run_debug_shell
tridge Jul 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions libraries/AP_HAL/Util.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,11 +44,6 @@ class AP_HAL::Util {
// set command line parameters to the eeprom on start
virtual void set_cmdline_parameters() {};

// run a debug shall on the given stream if possible. This is used
// to support dropping into a debug shell to run firmware upgrade
// commands
virtual bool run_debug_shell(AP_HAL::BetterStream *stream) = 0;

enum safety_state : uint8_t {
SAFETY_NONE,
SAFETY_DISARMED,
Expand Down
1 change: 0 additions & 1 deletion libraries/AP_HAL_ChibiOS/Util.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@ class ChibiOS::Util : public AP_HAL::Util {
return static_cast<Util*>(util);
}

bool run_debug_shell(AP_HAL::BetterStream *stream) override { return false; }
uint32_t available_memory() override;

// get path to custom defaults file for AP_Param
Expand Down
4 changes: 0 additions & 4 deletions libraries/AP_HAL_ESP32/Util.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,6 @@ class ESP32::Util : public AP_HAL::Util
return static_cast<Util*>(util);
}

bool run_debug_shell(AP_HAL::BetterStream *stream) override
{
return false;
}
uint32_t available_memory() override;

// Special Allocation Routines
Expand Down
2 changes: 0 additions & 2 deletions libraries/AP_HAL_Empty/Util.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,4 @@
#include "AP_HAL_Empty_Namespace.h"

class Empty::Util : public AP_HAL::Util {
public:
bool run_debug_shell(AP_HAL::BetterStream *stream) override { return false; }
};
1 change: 0 additions & 1 deletion libraries/AP_HAL_Linux/Util.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ class Util : public AP_HAL::Util {
}

void init(int argc, char *const *argv);
bool run_debug_shell(AP_HAL::BetterStream *stream) override { return false; }

/**
return commandline arguments, if available
Expand Down
4 changes: 0 additions & 4 deletions libraries/AP_HAL_SITL/Util.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,6 @@ class HALSITL::Util : public AP_HAL::Util {
Util(SITL_State *_sitlState) :
sitlState(_sitlState) {}

bool run_debug_shell(AP_HAL::BetterStream *stream) override {
return false;
}

/**
how much free memory do we have in bytes.
*/
Expand Down
Loading