AP_DroneCAN: Serial: Filter incoming messagess by target_node
#27521
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to description of
uavcan/tunnel/3001.Targetted.uavcanmessage the receiving node should filter messages based ontaget_nodeparameter but now it filters based on the assignedCAN_D1_UC_S1_NODnode id. As I see it, now it does not comply withWith this change, one can connect multiple - more than 3 - devices to one bus and make them all communicate over Mavlink.
For example, we're using this to have 10 slow sensors sending data and reacting to system status changes that it can receive via Mavlink messages and GCS should only handle Mavlink and not DroneCAN