AP_Notify: add support for blinking 1 LED for notify #27533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested on SDMODELH7V1. |
andyp1per
reviewed
Jul 11, 2024
|
I know there is at least one board that defines a second LED pin which is not really connected just so they get a blinky light. |
Ah, great, thanks for the confirmation. I thought, "surely we must blink LEDs on these boards that don't define 2+ LEDs". But I accepted the insanity and added support, half-thinking someone would point out some alternate pathway through which we blinked LEDs! |
|
Incidentally, suggestions for what patterns to show when are welcome. I juts put something together which looked like a good launching point. |
tridge
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... also a simulator for it