AP_Mount: Topotek safely parses version packet #27616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterbarker
reviewed
Jul 23, 2024
rmackay9
force-pushed
the
topotek-version-fix
branch
from
28e6036 to
106b7da
Compare
tridge
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This corrects a potential issue in the Topotek driver (introduced this morning by PR #27568) that could lead to writing past the end of the "version" variable while parsing the version packet received from the gimbal.
This has been lightly tested on real hardware but the exact code path affected is not run due to the hardware I'm using sending the old style version string
Thanks @peterbarker for finding this issue