Plane: Reset TECS along with the rest of the controllers #27827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Georacer this seems good, will you take it out of draft? |
If you're convinced by a draft PR and in my absence, maybe I should attend the Dev call less, haha. Yes, I'll convert it to a normal PR. |
Georacer
force-pushed
the
pr/wiggle-tecs-reset
branch
from
e9aa49b to
65dc003
Compare
Georacer
changed the title
There is a "shared change" in TECS.cpp that is necessary to get the results that I pasted in the images. |
Georacer
force-pushed
the
pr/wiggle-tecs-reset
branch
from
65dc003 to
9db8b8d
Compare
tridge
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the balloon drop use-case, I've noticed that TECS would initialize on the ground. That meant that the desired altitude (which is under an LPF) would not start close to the actual altitude, rendering itself useless for an RTL:
With this commit TECS starts at the release altitude, resulting in reasonable altitude error:
