SRV_Channels: find_channel: use channel mask remove need for search over all channels #27849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IamPete1
commented
Aug 15, 2024
Comment on lines
+569
to
+571
| if (!initialised) { | ||
| update_aux_servo_function(); | ||
| } |
There was a problem hiding this comment.
We do this in several places, we really should not have too.... We could remove it and put in a SITL only panic.
andyp1per
approved these changes
Aug 15, 2024
IamPete1
force-pushed
the
servo_find_channel
branch
from
48690dc to
e9f2515
Compare
|
Fixed a typo in a comment. |
tridge
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should speed up the find channel call so its less painful at higher rates. #27843
I have not tested this, or had a in depth look to see if its a good idea.I think this is OK, there will be slightly more lag when a function is changed, we should not be changing functions at runtime so I think its OK.