AP_NavEKF2: added EK2_OPTIONS #27852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmackay9
approved these changes
Aug 20, 2024
peterbarker
approved these changes
Aug 20, 2024
libraries/AP_NavEKF2/AP_NavEKF2.h
Outdated
| }; | ||
|
|
||
| // return true if an option is set | ||
| bool option_is_set(Options option) { |
There was a problem hiding this comment.
Suggested change
| bool option_is_set(Options option) { | |
| bool option_is_set(Options option) const { |
peterbarker
previously requested changes
Aug 20, 2024
libraries/AP_NavEKF2/AP_NavEKF2.h
Outdated
|
|
||
| // enum for processing options | ||
| enum class Options { |
There was a problem hiding this comment.
Suggested change
| enum class Options { | |
| enum class Option { |
tridge
commented
Aug 20, 2024
libraries/AP_NavEKF2/AP_NavEKF2.cpp
Outdated
|
|
||
| // @Param: OPTIONS | ||
| // @DisplayName: Optional EKF behaviour | ||
| // @Description: This controls optional EKF2 behaviour. Disabling external navigation prevents use of external vision data in the EKF2 solution |
There was a problem hiding this comment.
remove "this controls"
rmackay9
reviewed
Aug 20, 2024
libraries/AP_NavEKF2/AP_NavEKF2.cpp
Outdated
|
|
||
| // @Param: OPTIONS | ||
| // @DisplayName: Optional EKF behaviour | ||
| // @Description: This controls optional EKF2 behaviour. Disabling external navigation prevents use of external vision data in the EKF2 solution |
There was a problem hiding this comment.
let's remove the "This controls" because that's what all parameter do
this allows for disabling of external navigation data (such as visual odomotry) in EKF2. This is very useful when using EKF2 as a fallback and truth reference when testing visual odomotry on EKF3
tridge
force-pushed
the
pr-ekf2-disable-extnav
branch
from
4b4017a to
91f8f25
Compare
rmackay9
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this allows for disabling of external navigation data (such as visual odomotry) in EKF2. This is very useful when using EKF2 as a fallback and truth reference when testing visual odomotry on EKF3