-
Notifications
You must be signed in to change notification settings - Fork 17.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AP_GPS: support GNSS receiver resilience information over MAVLink #27891
base: master
Are you sure you want to change the base?
AP_GPS: support GNSS receiver resilience information over MAVLink #27891
Conversation
7277b75
to
1e45ab9
Compare
@tridge Do you have any idea on how to tackle the message being in development.xml for the integration? I am not sure when it would be appropriate for the message to be moved to common and the automatics checks fail because they do not have access to it unless I add it. |
The message is in ``development.xml` ,just not in our development.xml I've created a PR to add it to our development.xml: ArduPilot/mavlink#368 |
(params.gnss_mode&(1U<<6))!=0 ? ((params.gnss_mode&0x2F)==0 ? "GLONASS" : "+GLONASS") : "") == -1) { | ||
config_string=nullptr; | ||
} | ||
//IMES not taken into account by Septentrio receivers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this commented out? Did it work in the first place? Why was it here then?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is part of the possible constellation choice in Mission Planner, I thought it would make it clear for future users and maintainers why it is not a possibility
libraries/AP_GPS/AP_GPS_SBF.cpp
Outdated
const msg4092 &temp = sbf_msg.data.msg4092u; | ||
check_new_itow(temp.TOW, sbf_msg.length); | ||
#if HAL_GCS_ENABLED | ||
if (temp.Flags==0) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tabs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's been corrected
1e45ab9
to
6d20963
Compare
I've merged a PR to master to reference the GNSS_INTEGRITY message now Rebasing this should cause the tests to be happy again. ... also, can we close #26990 ? |
I will test it then! |
12c5413
to
fb16c70
Compare
Add support for reporting resilience information from GNSS receivers (interference & authentication) over MAVLink.
fb16c70
to
d2a2107
Compare
Add support for reporting resilience information from GNSS receivers (system status & interference & authentication) over MAVLink. These information have been added in Mavlink recently and this implements it in the code, for now it is only available with Septentrio receivers.
For testing it, I had to move the message to common.xml as they are currently in development.xml. This should not be an issue once the implementation is complete and the message can be moved to common.
While for now I could only test that it built correctly, and that the function to send the message to mavlink was correctly called with accurate data fed to it. I will need to modify Mission Planner to ensure that it's fully compatible.