Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AP_GPS: support GNSS receiver resilience information over MAVLink #27891

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

chiara-septentrio
Copy link
Contributor

Add support for reporting resilience information from GNSS receivers (system status & interference & authentication) over MAVLink. These information have been added in Mavlink recently and this implements it in the code, for now it is only available with Septentrio receivers.
For testing it, I had to move the message to common.xml as they are currently in development.xml. This should not be an issue once the implementation is complete and the message can be moved to common.

While for now I could only test that it built correctly, and that the function to send the message to mavlink was correctly called with accurate data fed to it. I will need to modify Mission Planner to ensure that it's fully compatible.

@chiara-septentrio chiara-septentrio marked this pull request as draft August 21, 2024 15:07
@chiara-septentrio
Copy link
Contributor Author

@tridge Do you have any idea on how to tackle the message being in development.xml for the integration? I am not sure when it would be appropriate for the message to be moved to common and the automatics checks fail because they do not have access to it unless I add it.

@peterbarker
Copy link
Contributor

@tridge Do you have any idea on how to tackle the message being in development.xml for the integration? I am not sure when it would be appropriate for the message to be moved to common and the automatics checks fail because they do not have access to it unless I add it.

The message is in ``development.xml` ,just not in our development.xml

I've created a PR to add it to our development.xml: ArduPilot/mavlink#368

(params.gnss_mode&(1U<<6))!=0 ? ((params.gnss_mode&0x2F)==0 ? "GLONASS" : "+GLONASS") : "") == -1) {
config_string=nullptr;
}
//IMES not taken into account by Septentrio receivers
Copy link
Contributor

@amilcarlucas amilcarlucas Aug 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this commented out? Did it work in the first place? Why was it here then?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is part of the possible constellation choice in Mission Planner, I thought it would make it clear for future users and maintainers why it is not a possibility

const msg4092 &temp = sbf_msg.data.msg4092u;
check_new_itow(temp.TOW, sbf_msg.length);
#if HAL_GCS_ENABLED
if (temp.Flags==0) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tabs

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's been corrected

@peterbarker
Copy link
Contributor

I've merged a PR to master to reference the GNSS_INTEGRITY message now

Rebasing this should cause the tests to be happy again.

... also, can we close #26990 ?

@chiara-septentrio
Copy link
Contributor Author

I will test it then!
You can close #26990, it's not my PR so I can't close it (as far as I know) but it's outdated now.

@chiara-septentrio chiara-septentrio force-pushed the pr-resilience branch 2 times, most recently from 12c5413 to fb16c70 Compare September 4, 2024 14:38
@chiara-septentrio chiara-septentrio marked this pull request as ready for review September 4, 2024 17:13
Add support for reporting resilience information from GNSS receivers
(interference & authentication) over MAVLink.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants