Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plane: add flag to disable wp speed scaling on heading and groundtrack #27953

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

magate
Copy link
Contributor

@magate magate commented Aug 29, 2024

When performing a moving landing it is possible to have the prevailing headwind not in the direction of travel of the moving target. In this case is it undesirable to have the groundspeed scaled.

This adds a flag to optionally disable: #17751

image
Moving platform example.

@magate magate force-pushed the disable-wp-speed-scaling-in-pos-1 branch from 3876f9a to cec3820 Compare August 29, 2024 21:15
@Hwurzburg Hwurzburg requested a review from tridge August 30, 2024 04:56
@Hwurzburg Hwurzburg added the WikiNeeded needs wiki update label Aug 30, 2024
Copy link
Contributor

@peterbarker peterbarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to compile.

You're trying to use a 32-bit value to store a single bit of information; consider using a Q_OPTION bit instead

@magate magate force-pushed the disable-wp-speed-scaling-in-pos-1 branch from cec3820 to 745d2ca Compare September 4, 2024 16:03
@magate
Copy link
Contributor Author

magate commented Sep 4, 2024

Q_OPTIONS 0
image

Q_OPTIONS 8388608 which is 2^23
image

Conditional waypoint hit instead of early exit showing the bit flag gated the code.

@magate magate requested a review from peterbarker September 4, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WikiNeeded needs wiki update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants