Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename SPL06 to SPx06 #27992

Closed
wants to merge 3 commits into from
Closed

Conversation

peterbarker
Copy link
Contributor

@peterbarker peterbarker commented Sep 3, 2024

I've built this branch for every target, blimp-only.

Binary output is identical except where the hwdefs have been modifed.

Extracted from https://github.com/ArduPilot/ardupilot/pull/27905/files

pbarker@threads:~$ ~/rc/ardupilot/Tools/scripts/filter_size_compare_branches_csv.py /tmp/some.csv  --hide-bin
------------------------  -----  ----------
Board                     blimp  bootloader
AtomRCF405NAVI            0      *
FlyingMoonF427            0      *
FlyingMoonH743            0      *
FlywooF745                0      *
FlywooF745Nano            0      *
IFLIGHT_2RAW_H7           0      *
MambaF405-2022            0      *
MambaH743v4               0      *
MatekF405-TE              0      *
MatekF405-TE-bdshot       0      *
MicoAir405v2              0      *
R9Pilot                   0      *
SITL_arm_linux_gnueabihf  0
SITL_x86_64_linux_gnu     0
SpeedyBeeF405WING         0      *
bbbmini                   0
blue                      0
canzero                   0
edge                      0
erlebrain2                0
navigator                 0
navio                     0
navio2                    0
obal                      0
pxf                       0
pxfmini                   0
speedybeef4v3             0      *
speedybeef4v4             0      *
------------------------  -----  ----------
pbarker@threads:~$ 

@tridge
Copy link
Contributor

tridge commented Sep 4, 2024

I'd prefer just a comment in the top of the SPL06 driver saying it supports SPA06 as well

@tridge tridge removed the DevCallEU label Sep 4, 2024
@radiolinkW
Copy link
Contributor

I'd prefer just a comment in the top of the SPL06 driver saying it supports SPA06 as well

What if there is still SPB06? And SPA06 was not originally part of SPL06.

How was the discussion at your DevCallEU going?

@peterbarker peterbarker closed this Sep 5, 2024
@peterbarker peterbarker deleted the pr/spl06-rename branch September 5, 2024 09:32
@peterbarker
Copy link
Contributor Author

I'd prefer just a comment in the top of the SPL06 driver saying it supports SPA06 as well

What if there is still SPB06? And SPA06 was not originally part of SPL06.

How was the discussion at your DevCallEU going?

I've commented on your PR explaining what happened.

Hopefully into the future we can do something like we do for the Invensense drivers - so if the protocol changes we add "v2" or "v3" on the end. And to know which driver supports what you check the comments at the top of the file.

Again, apologies for the run-around with the rename - you suggested it, I thought it was a good idea - it wasn't :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants