Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copter: remove ENABLE/ENABLED/DISABLE/DISABLED defines #28004

Merged

Conversation

peterbarker
Copy link
Contributor

No compiler output changes except where expected (the SkyVipers have ENABLED/DISABLED in their hwdef.dats)

Last vehicle!

Every 2.0s: /home/pbarker/rc/ardupil...  threads: Wed Sep  4 17:35:57 2024

------------------------  -----  ------  ----  -----  -----  ---
Board                     blimp  copter  heli  plane  rover  sub
SITL_arm_linux_gnueabihf  0      0       0     0      0      0
SITL_x86_64_linux_gnu     0      0       0     0      0      0
skyviper-f412-rev1               -8
skyviper-journey                 0
skyviper-v2450                   -8
------------------------  -----  ------  ----  -----  -----  ---

Copy link
Contributor

@amilcarlucas amilcarlucas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@tridge tridge requested a review from rmackay9 September 4, 2024 09:16
@tridge tridge removed the DevCallEU label Sep 4, 2024
Copy link
Contributor

@rmackay9 rmackay9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. I'm not a huge fan of replacing ENABLED/DISABLED with 1/0 in the APM_Config.h file but I think we're moving away from using APM_Config anyway and I certainly like the rest of the change so I'm not going to hold things up

@peterbarker peterbarker force-pushed the pr/copter-remove-enabled-disabled branch from 8c11bd8 to c1145e6 Compare September 5, 2024 22:47
@peterbarker peterbarker merged commit 7847603 into ArduPilot:master Sep 6, 2024
73 checks passed
@peterbarker peterbarker deleted the pr/copter-remove-enabled-disabled branch September 7, 2024 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants