Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AP_DroneCAN: Set protocol in tunnel.Targetted message #28018

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

olliw42
Copy link
Contributor

@olliw42 olliw42 commented Sep 5, 2024

This sets the protocol field in the tunnel.Targetted DroneCAN message, which is used by the AP_DroneCAN_serial class for doing serial over CAN.

This can be useful, e.g., for recipients to check that they get what they expect to get.

Tested on a MatekH743 loaded with ArduPlane.

@tpwrules
Copy link
Contributor

tpwrules commented Sep 5, 2024

Previous discussion: #27902

@peterbarker
Copy link
Contributor

Closes #27902

@olliw42
Copy link
Contributor Author

olliw42 commented Sep 7, 2024

fyi, that's why I don't agree with the arguments in #27902:

https://youtu.be/Utlcfp1Z4cg

@tridge tridge merged commit 3c9965f into ArduPilot:master Sep 10, 2024
93 checks passed
@olliw42
Copy link
Contributor Author

olliw42 commented Sep 10, 2024

THX

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants