Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AP_NavEKF3: Align CORE determination with other methods #28041

Conversation

muramura
Copy link
Contributor

@muramura muramura commented Sep 8, 2024

The CORE determination is different! CORE, CORE != NULLPTR.
I think it would be better to align them.

Copy link
Contributor

@peterbarker peterbarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our standard is to compare against nullptr as it adds a very small amount of type-safety.

Note that we won't typically move from !pointer to pointer == nullptr just because, but if you're modifying code in the area we will.

if (core == nullptr) {
if (!core) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

core == nullptr is our current standard.

This patch moves us away from that standard.

@peterbarker
Copy link
Contributor

Closing this one as it moves us further from our standard

@peterbarker peterbarker closed this Sep 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants