Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SkySakura H743 fc Support #28094

Merged
merged 1 commit into from
Nov 7, 2024
Merged

SkySakura H743 fc Support #28094

merged 1 commit into from
Nov 7, 2024

Conversation

BloodSakura3774
Copy link
Contributor

SkySakura H743 fc Support

@Hwurzburg Hwurzburg added the WikiNeeded needs wiki update label Sep 13, 2024
@Hwurzburg Hwurzburg self-requested a review September 13, 2024 20:28
@BloodSakura3774
Copy link
Contributor Author

May I ask if this will be merged and included in copter 4.5.7?

@Hwurzburg Hwurzburg requested a review from peterbarker October 8, 2024 00:07
Hwurzburg
Hwurzburg requested changes Oct 8, 2024
View reviewed changes
Copy link
Collaborator

@Hwurzburg Hwurzburg left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in addition to comments, this needs a bootloader and you should consider enabling SD card in thee bootloader for updating firmware via SD card

as to backports, that can be decided after this gets merged since 4.6 is about to release

also, it would be good to send a few boards to support devs in case something arises that needs board testing .... @andyp1per , @PeteBarker, and or myself would be good potential recipients, if you desire...

libraries/AP_HAL_ChibiOS/hwdef/SkySakuraH743/README.md
@@ -0,0 +1,105 @@
# SkySakura H743 Flight Controller

The SkySakura H743 is a flight controller produced by [SkySakuraRC]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need url link here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not ready yet, will add when ready.

libraries/AP_HAL_ChibiOS/hwdef/SkySakuraH743/README.md Outdated Show resolved Hide resolved
libraries/AP_HAL_ChibiOS/hwdef/SkySakuraH743/README.md Outdated Show resolved Hide resolved
libraries/AP_HAL_ChibiOS/hwdef/SkySakuraH743/README.md Show resolved Hide resolved
libraries/AP_HAL_ChibiOS/hwdef/SkySakuraH743/README.md Outdated Show resolved Hide resolved
libraries/AP_HAL_ChibiOS/hwdef/SkySakuraH743/hwdef.dat Outdated Show resolved Hide resolved
libraries/AP_HAL_ChibiOS/hwdef/SkySakuraH743/hwdef.dat Show resolved Hide resolved
libraries/AP_HAL_ChibiOS/hwdef/SkySakuraH743/hwdef.dat Show resolved Hide resolved
libraries/AP_HAL_ChibiOS/hwdef/SkySakuraH743/hwdef.dat Outdated Show resolved Hide resolved
libraries/AP_HAL_ChibiOS/hwdef/SkySakuraH743/defaults.parm Outdated Show resolved Hide resolved
@BloodSakura3774
Copy link
Contributor Author

BloodSakura3774 commented Oct 10, 2024 •
edited
Loading

in addition to comments, this needs a bootloader and you should consider enabling SD card in thee bootloader for updating firmware via SD card

Added, but I'm not sure if the defines are correct.

also, it would be good to send a few boards to support devs in case something arises that needs board testing .... @andyp1per , @PeteBarker, and or myself would be good potential recipients, if you desire...

We have contacted Andy and got his address month ago, but we are still waiting for first batches to arrive. Will be providing samples to other devs.

@BloodSakura3774 BloodSakura3774 force-pushed the fc_support branch 2 times, most recently from ef1a0c1 to 46963c1 Compare October 18, 2024 15:42
@BloodSakura3774
Copy link
Contributor Author

Sorry, but the bootloader is added now. Is there any other problem with this pr?

@Hwurzburg
Copy link
Collaborator

has this been tested now on final hardware?

@BloodSakura3774
Copy link
Contributor Author

Yes it is, this is the last commit for correcting the hwdef.

@BloodSakura3774
Copy link
Contributor Author

Should I do a squash now or later when you are finish reviewing it?

@Hwurzburg
Copy link
Collaborator

@BloodSakura3774 nothing more (except link to how to buy before I can make a wiki page after this is merged) is needed and I have marked it for dev team consideration for merging

@BloodSakura3774
Copy link
Contributor Author

website is currently not ready, we have not planned to sell is outside of china yet, will add once its ready

@BloodSakura3774 @tridge
hwdef: SkySakura H743 fc Support
cc81e2c 
SkySakura H743 fc Support
@peterbarker peterbarker merged commit c709959 into ArduPilot:master Nov 7, 2024
47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hwurzburg Hwurzburg Hwurzburg approved these changes

@peterbarker peterbarker Awaiting requested review from peterbarker

Assignees
No one assigned
Labels
MergeOnCIPass NewBoardSupport WikiNeeded needs wiki update
Projects
4.5 Backports
Status: Pending
4.6 Backports
Status: 4.6.0-beta2
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@BloodSakura3774 @Hwurzburg @tridge @CraigElder @peterbarker