Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tools: Add astyle dependency #28561

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

Ryanf55
Copy link
Collaborator

@Ryanf55 Ryanf55 commented Nov 8, 2024

Experimenting to see if we can install astyle by default and start enabling astyle cleanlyness on Ubuntu.

Signed-off-by: Ryan Friedman <[email protected]>
@Ryanf55
Copy link
Collaborator Author

Ryanf55 commented Nov 11, 2024

To the dev team: What do you want tested before we would merge this? The most comprehensive would be running astyle on all distros and seeing if there's code diff.

So far, I've checked astyle versions 3.1 and 3.6.4, which show no code diff.

CI enforces the version from Ubuntu 22 (3.1).

@Ryanf55 Ryanf55 requested a review from tridge November 12, 2024 01:59
@tridge tridge marked this pull request as ready for review November 12, 2024 02:01
@tridge tridge added MergeOnCIPass and removed WIP labels Nov 12, 2024
@tridge tridge merged commit 1e7cd71 into ArduPilot:master Nov 12, 2024
15 checks passed
@Ryanf55 Ryanf55 deleted the astyle-install-in-prereqs branch November 12, 2024 02:01
@Ryanf55
Copy link
Collaborator Author

Ryanf55 commented Nov 12, 2024

@khancyr We're one step closer to getting pre-commit easier to use with regular workflow. The next step is to add support for this in our pre-commit file. Just FYI, if you wanted to help out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants