CANManager: support CAN frame logging #28779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tridge
force-pushed
the
pr-can-frame-logging
branch
3 times, most recently
from
33f4e3b to
9d4032b
Compare
this supports logging of all bxCAN and CANFD frames, which helps with debugging tricky CAN support issues and for the development of new CAN driver lua scripts
tridge
force-pushed
the
pr-can-frame-logging
branch
from
9d4032b to
94e0e24
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for logging all incoming CAN frames in a form that can be played back by a python script. It is enabled using a CAN_Pn_OPTIONS bit.
I have been doing this for quite some time with a lua script in examples/CAN_logger.lua, but that only works for can interfaces set to scripting, and it also can miss frames, plus does not support CANFD.
The utility of this functionality is:
The overhead of the logging approach is quite low, as is flash cost.
I've marked this for 4.6 as it will be so useful for supporting users, but it may be more suitable for a bit later 4.6.x release