Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AP_InertialSensor: stop sensors converging if motors arm #28783

Merged
merged 1 commit into from
Dec 8, 2024

Conversation

tridge
Copy link
Contributor

@tridge tridge commented Nov 30, 2024

if the user arms within 30s of startup then stop the re-init of the sensors. This can give less accurate frequency as the sample rate may not have settled yet, but it is better than doing init of the filters while the vehicle may be flying

also fix a 32 bit millis wrap

if the user arms within 30s of startup then stop the re-init of the
sensors. This can give less accurate frequency as the sample rate may
not have settled yet, but it is better than doing init of the filters
while the vehicle may be flying

also fix a 32 bit millis wrap
@tridge tridge requested a review from andyp1per November 30, 2024 09:49
@IamPete1
Copy link
Member

Wouldn't it be better to add a pre-arm that the sensors have converged? Could we stash the result of the convergence from the last time in a hidden param that would short cut the convergence?

@tridge
Copy link
Contributor Author

tridge commented Dec 2, 2024

Wouldn't it be better to add a pre-arm that the sensors have converged?

I think FPV pilots often do want to do quick takeoffs, and waiting the full 30s is unlikely to be important enough to hold up the flight.

@andyp1per
Copy link
Collaborator

I think FPV pilots often do want to do quick takeoffs, and waiting the full 30s is unlikely to be important enough to hold up the flight.

Exactly

@tridge tridge merged commit 4d31a73 into ArduPilot:master Dec 8, 2024
99 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 4.6.0-beta2
Development

Successfully merging this pull request may close these issues.

3 participants