Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove superfluous linefeed from panic strings #28853

Merged
merged 14 commits into from
Dec 13, 2024
Merged

Remove superfluous linefeed from panic strings #28853

merged 14 commits into from
Dec 13, 2024

Conversation

peterbarker
Copy link
Contributor

panic adds this within the HAL layer.

@peterbarker
AP_AHRS: remove superfluous linefeed from panic strings
bff0f06 
panic adds this within the HAL layer.
@peterbarker
AP_DDS: remove superfluous linefeed from panic strings
dfbc5ca 
panic adds this within the HAL layer.
@peterbarker
AP_FlashStorage: remove superfluous linefeed from panic strings
255ba39 
panic adds this within the HAL layer.
@peterbarker
AP_HAL_ChibiOS: remove superfluous linefeed from panic strings
9514a0f 
panic adds this within the HAL layer.
@peterbarker
AP_HAL_Linux: remove superfluous linefeed from panic strings
0756d1e 
panic adds this within the HAL layer.
@peterbarker
AP_HAL_SITL: remove superfluous linefeed from panic strings
e21639e 
panic adds this within the HAL layer.
@peterbarker
AP_InertialSensor: remove superfluous linefeed from panic strings
f7188e2 
panic adds this within the HAL layer.
@peterbarker
AP_InternalError: remove superfluous linefeed from panic strings
ea4bf28 
panic adds this within the HAL layer.
@peterbarker
AP_Logger: remove superfluous linefeed from panic strings
57ac07b 
panic adds this within the HAL layer.
@peterbarker
AP_Param: remove superfluous linefeed from panic strings
51e6c4d 
panic adds this within the HAL layer.
@peterbarker
AP_Radio: remove superfluous linefeed from panic strings
9df3101 
panic adds this within the HAL layer.
@peterbarker
AP_RCProtocol: remove superfluous linefeed from panic strings
c133c90 
panic adds this within the HAL layer.
@peterbarker
SITL: remove superfluous linefeed from panic strings
5c9ca31 
panic adds this within the HAL layer.
@peterbarker
Tools: remove superfluous linefeed from panic strings
49408c6 
panic adds this within the HAL layer.
rmackay9
rmackay9 approved these changes Dec 13, 2024
View reviewed changes
Copy link
Contributor

@rmackay9 rmackay9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I looked through it and it all looks fine. there's one end-of-file line feed added which is also fine

IamPete1
IamPete1 approved these changes Dec 13, 2024
View reviewed changes
Copy link
Member

@IamPete1 IamPete1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@peterbarker peterbarker merged commit b5ba096 into ArduPilot:master Dec 13, 2024
99 checks passed
@peterbarker
Copy link
Contributor Author

LGTM. I looked through it and it all looks fine. there's one end-of-file line feed added which is also fine

Yeah, I was a bit vexed at that LF when reviewing it in github but was tired and lazy - sorry!

@peterbarker peterbarker deleted the pr/panic-no-lf branch December 14, 2024 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmackay9 rmackay9 rmackay9 approved these changes

@andyp1per andyp1per andyp1per approved these changes

@IamPete1 IamPete1 IamPete1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@peterbarker @rmackay9 @andyp1per @IamPete1