Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev: Add ROS 2 page for Gazebo integration #5359

Merged
merged 2 commits into from
Aug 18, 2023

Conversation

pedro-fuoco
Copy link
Contributor

I plan on adding a quick youtube video showing the gazebo world with a copter in it, it would be nice to have that before merge.
After this PR I will add a SLAM related page to the wiki.

The technical details have been heavily based on the ardupilot_gz README from @srmainwaring, and is linked in the page

@Hwurzburg
Copy link
Contributor

LGTM, can merge now and add video later, or mark it WIP until then...your choice

@pedro-fuoco
Copy link
Contributor Author

pedro-fuoco commented Aug 16, 2023

@Hwurzburg thanks for the review!
I just added the video, we can merge now. Next time I will mark it as WIP beforehand

@Hwurzburg
Copy link
Contributor

I am going to move the video to the ArduPilot site and update the link and then merge...thanks

@pedro-fuoco
Copy link
Contributor Author

I am going to move the video to the ArduPilot site and update the link and then merge...thanks

@Hwurzburg okk, thanks. As soon as this merges I will submit a PR for ros2-cartographer-slam.rst

@Hwurzburg
Copy link
Contributor

Hwurzburg commented Aug 18, 2023

@pedro-fuoco use this video link in the PR... HZKXrSAE-ac

@Hwurzburg
Copy link
Contributor

LGTM thanks

@Hwurzburg Hwurzburg merged commit d93572d into ArduPilot:master Aug 18, 2023
4 checks passed
@pedro-fuoco pedro-fuoco deleted the add-ros2-gz branch August 19, 2023 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants