Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix to authManager and statistics frontend support #145

Merged
merged 18 commits into from
Mar 31, 2024
Merged

Fix to authManager and statistics frontend support #145

merged 18 commits into from
Mar 31, 2024

Conversation

jjgancfer
Copy link
Contributor

Due to @gony02 and @UO283615 needing to work with this, I request a premature PR containing the following changes:

  • Many tests are being deleted (either due to being duplicated, or due to me considering they'd better be reworked as e2e tests).
  • Fixed app private routing not working correctly. Now it is necessary to be logged in to enter those pages in which the user should be. Note there is a known deficiency: refreshing the content redirects to the login page (I was working on this when urged to merge).
  • Statistics support in the frontend. There are nearly no tests for this, so I expect SonarCloud to fail.

I will be addressing the inadequacies in the last two points in the future.

jjgancfer added 18 commits March 25, 2024 13:14
@jjgancfer
feat: send Authorization header with token
5455262
@jjgancfer
feat: add skeleton of statistics page
894d758
@jjgancfer
chore: replace green colour with blue
705e65b
@jjgancfer
feat: disable legend toggle
e0a82f3
@jjgancfer
feat: add structure of personal statistics
b2d1497
@jjgancfer
feat: finalised statistics page (tests and backend connection are sti…
c82d647 
…ll missing)
@jjgancfer
feat: add circular progress to reflect connectivity
56858de
@jjgancfer
chore: code refactor to separate dashboard button
fe51c55
@jjgancfer
Merge remote-tracking branch 'origin/develop' into feat/webapp/statis…
4210801 
…tics
@jjgancfer
feat: removed auto logout when loading login if already logged in
daba2f9
@jjgancfer
refactor: replace AuthUtils for AuthManager
742a57f
@jjgancfer
feat: independent logout endpoint
a02f30b
@jjgancfer
feat: refactor of tests
7c98208 
 - Delete some redundant tests
 - Delete some tests that test behaviour separated since
@jjgancfer
chore: refactor tests to pass with new auth architecture
6d307bd
@jjgancfer
feat: solve unkown error message appearing when signing in
8fde055
@jjgancfer
chore: add some initial testing
98b1cd6
@jjgancfer
feat: add some statistics connectivity
f4feeaf
@jjgancfer
feat: initial session preservation
3571293
@jjgancfer jjgancfer added enhancement 🆕 New feature or request frontend 👁️ Frontend issue ASAP 🚨 Urgent issue labels Mar 30, 2024
@jjgancfer jjgancfer added this to the Third delivery milestone Mar 30, 2024
@jjgancfer jjgancfer requested review from gony02 and UO283615 March 30, 2024 20:43
@jjgancfer jjgancfer self-assigned this Mar 30, 2024
@jjgancfer jjgancfer linked an issue Mar 30, 2024 that may be closed by this pull request
Create the leaderboard view #141
Closed
@UO283615 UO283615 merged commit 4dc37e5 into develop Mar 31, 2024
1 check failed
@jjgancfer jjgancfer deleted the feat/webapp/statistics branch March 31, 2024 18:05
This was referenced Apr 2, 2024
Closed
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@UO283615 UO283615 UO283615 approved these changes

@gony02 gony02 gony02 approved these changes

Assignees

@jjgancfer jjgancfer

Labels
ASAP 🚨 Urgent issue enhancement 🆕 New feature or request frontend 👁️ Frontend issue
Projects
None yet
Milestone
Third delivery
Development

Successfully merging this pull request may close these issues.

Create the leaderboard view
3 participants
@jjgancfer @gony02 @UO283615