[XML Converter] Save Protobins within Godot #159
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klingbolt
changed the title
|
Replaced by #265. Closing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split from #154
Dependent on #157
Addressing Issue [XML Markers] Save Marker Protobins from GDScript #78
Addresses the questions posed in the issue by saving all data when the save button is pressed. The average user would not make a distinction of saving one pack's data and not another. Same principle applies to switching maps. By saving all data, you are also not required to be in the map where the changes have been made.
Finally, an autosave check was added before a new maps data is loaded. This could be augmented further to catch changes within x amount of time.