[XML Converter] Save Protobins within Godot #265
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AsherGlick
requested changes
Jan 19, 2024
There was a problem hiding this comment.
Can you split this up into 2 PRs.
- save to split proto from ingame state
- save to "export"? proto from split proto
From our previous conversation may have erroneously assumed that the former had already been completed and I think that there is going to be some discussion required on that point. While I have fewer comments about the latter.
| @@ -9,7 +9,7 @@ | |||
| config_version=4 | |||
|
|
|||
| _global_script_classes=[ { | |||
| "base": "Node", | |||
| "base": "", | |||
| @@ -784,6 +796,7 @@ margin_bottom = 304.0 | |||
| text = "Load Lutris Profile" | |||
|
|
|||
| [node name="CategoriesDialog" type="WindowDialog" parent="Control/Dialogs"] | |||
| visible = true | |||
Comment on lines
+206
to
+207
| current_dir = "." | ||
| current_path = "." |
Comment on lines
+198
to
+202
| visible = true | ||
| margin_left = 777.0 | ||
| margin_top = 89.0 | ||
| margin_right = 1448.0 | ||
| margin_bottom = 587.0 |
|
|
||
| func save_from_split_files(): | ||
| save_current_map_data() | ||
| for waypoint_category in self.waypoint_data.get_category(): |
There was a problem hiding this comment.
Do we need to "save" every top-level category every time the button is pressed?
|
This PR is now obsolete and its goals covered by other PRs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replacing #159
Changes to markers are saved in the split files. A save button takes those split files and saves them to individual files.