Changed render_on_minimap to is_hidden_on_minimap #352
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There was a problem hiding this comment. Full Diff--- xml_converter/integration_tests/test_cases/proto_is_hidden_on_minimap/input/pack/markers.bin.textproto._old 2024-09-12 03:38:57.778270223 +0000
+++ xml_converter/integration_tests/test_cases/proto_is_hidden_on_minimap/input/pack/markers.bin.textproto._new 2024-09-12 03:38:57.786270355 +0000
@@ -0,0 +1,26 @@
+category {
+ name: "My Category"
+ icon {
+ map_id: 50
+ position {
+ x: 169.81
+ y: 210.65
+ z: 215.83
+ }
+ 36: 1
+ }
+ icon {
+ map_id: 50
+ position {
+ x: 169.81
+ y: 210.65
+ z: 215.83
+ }
+ }
+ trail {
+ 33: 1
+ }
+ trail {
+ }
+ id: "(\350\314\006\302\223^\226"
+}
There was a problem hiding this comment. Full Diff--- xml_converter/integration_tests/test_cases/proto_is_hidden_on_minimap/input/pack/markers.bin.textproto._old 2024-09-19 03:37:03.408146459 +0000
+++ xml_converter/integration_tests/test_cases/proto_is_hidden_on_minimap/input/pack/markers.bin.textproto._new 2024-09-19 03:37:03.416146473 +0000
@@ -0,0 +1,26 @@
+category {
+ name: "My Category"
+ icon {
+ map_id: 50
+ position {
+ x: 169.81
+ y: 210.65
+ z: 215.83
+ }
+ 36: 1
+ }
+ icon {
+ map_id: 50
+ position {
+ x: 169.81
+ y: 210.65
+ z: 215.83
+ }
+ }
+ trail {
+ 33: 1
+ }
+ trail {
+ }
+ id: "(\350\314\006\302\223^\226"
+}
|
Binary file not shown.
|
There was a problem hiding this comment. Full Diff--- xml_converter/integration_tests/test_cases/proto_is_hidden_on_minimap/output_proto/markers.bin.textproto._old 2024-09-11 01:17:56.318697789 +0000
+++ xml_converter/integration_tests/test_cases/proto_is_hidden_on_minimap/output_proto/markers.bin.textproto._new 2024-09-11 01:17:56.326697739 +0000
@@ -0,0 +1,21 @@
+category {
+ name: "My Category"
+ icon {
+ map_id: 50
+ position {
+ x: 169.81
+ y: 210.65
+ z: 215.83
+ }
+ 36: 1
+ }
+ icon {
+ map_id: 50
+ position {
+ x: 169.81
+ y: 210.65
+ z: 215.83
+ }
+ }
+ id: "(\350\314\006\302\223^\226"
+}
There was a problem hiding this comment. Full Diff--- xml_converter/integration_tests/test_cases/proto_is_hidden_on_minimap/output_proto/markers.bin.textproto._old 2024-09-12 03:38:57.818270880 +0000
+++ xml_converter/integration_tests/test_cases/proto_is_hidden_on_minimap/output_proto/markers.bin.textproto._new 2024-09-12 03:38:57.826271011 +0000
@@ -0,0 +1,26 @@
+category {
+ name: "My Category"
+ icon {
+ map_id: 50
+ position {
+ x: 169.81
+ y: 210.65
+ z: 215.83
+ }
+ 36: 1
+ }
+ icon {
+ map_id: 50
+ position {
+ x: 169.81
+ y: 210.65
+ z: 215.83
+ }
+ }
+ trail {
+ 33: 1
+ }
+ trail {
+ }
+ id: "(\350\314\006\302\223^\226"
+}
There was a problem hiding this comment. Full Diff--- xml_converter/integration_tests/test_cases/proto_is_hidden_on_minimap/output_proto/markers.bin.textproto._old 2024-09-19 03:37:03.424146487 +0000
+++ xml_converter/integration_tests/test_cases/proto_is_hidden_on_minimap/output_proto/markers.bin.textproto._new 2024-09-19 03:37:03.431146500 +0000
@@ -0,0 +1,26 @@
+category {
+ name: "My Category"
+ icon {
+ map_id: 50
+ position {
+ x: 169.81
+ y: 210.65
+ z: 215.83
+ }
+ 36: 1
+ }
+ icon {
+ map_id: 50
+ position {
+ x: 169.81
+ y: 210.65
+ z: 215.83
+ }
+ }
+ trail {
+ 33: 1
+ }
+ trail {
+ }
+ id: "(\350\314\006\302\223^\226"
+}
|
Binary file not shown.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| <OverlayData> | ||
| <MarkerCategory DisplayName="My Category" ID="KOjMBsKTXpY=" Name="mycategory"> | ||
| </MarkerCategory> | ||
|
|
||
| <POIs> | ||
| <POI Type="mycategory" MapID="50" XPos="169.809998" YPos="210.649994" ZPos="215.830002" MinimapVisibility="false"/> | ||
| <POI Type="mycategory" MapID="50" XPos="169.809998" YPos="210.649994" ZPos="215.830002"/> | ||
| <Trail Type="mycategory" MinimapVisibility="false"/> | ||
| <Trail Type="mycategory"/> | ||
| </POIs> | ||
| </OverlayData> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| input_paths: | ||
| "pack": "proto" | ||
| expected_stdout: | | ||
| expected_stderr: | | ||
| expected_returncode: 0 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| <OverlayData> | ||
| <MarkerCategory DisplayName="My Category" Name="mycategory"> | ||
| </MarkerCategory> | ||
|
|
||
| <POIs> | ||
| <POI MinimapVisibility="false" Type="mycategory" XPos="169.81" YPos="210.65" ZPos="215.83" MapID="50" /> | ||
| <POI MinimapVisibility="0" Type="mycategory" XPos="169.81" YPos="210.65" ZPos="215.83" MapID="50" /> | ||
| <POI MinimapVisibility="true" Type="mycategory" XPos="169.81" YPos="210.65" ZPos="215.83" MapID="50" /> | ||
| <POI MinimapVisibility="1" Type="mycategory" XPos="169.81" YPos="210.65" ZPos="215.83" MapID="50" /> | ||
| <POI BHMinimapVisibility="false" Type="mycategory" XPos="169.81" YPos="210.65" ZPos="215.83" MapID="50" /> | ||
| <POI BHMinimapVisibility="0" Type="mycategory" XPos="169.81" YPos="210.65" ZPos="215.83" MapID="50" /> | ||
| <POI BHMinimapVisibility="true" Type="mycategory" XPos="169.81" YPos="210.65" ZPos="215.83" MapID="50" /> | ||
| <POI BHMinimapVisibility="1" Type="mycategory" XPos="169.81" YPos="210.65" ZPos="215.83" MapID="50" /> | ||
| <Trail MinimapVisibility="false" Type="mycategory" /> | ||
| <Trail MinimapVisibility="0" Type="mycategory" /> | ||
| <Trail MinimapVisibility="true" Type="mycategory" /> | ||
| <Trail MinimapVisibility="1" Type="mycategory" /> | ||
| <Trail BHMinimapVisibility="false" Type="mycategory" /> | ||
| <Trail BHMinimapVisibility="0" Type="mycategory" /> | ||
| <Trail BHMinimapVisibility="true" Type="mycategory" /> | ||
| <Trail BHMinimapVisibility="1" Type="mycategory" /> | ||
| </POIs> | ||
| </OverlayData> |
|
There was a problem hiding this comment. Full Diff--- xml_converter/integration_tests/test_cases/xml_render_on_minimap/output_proto/markers.bin.textproto._old 2024-09-11 01:17:56.334697690 +0000
+++ xml_converter/integration_tests/test_cases/xml_render_on_minimap/output_proto/markers.bin.textproto._new 2024-09-11 01:17:56.342697639 +0000
@@ -0,0 +1,72 @@
+category {
+ name: "My Category"
+ icon {
+ map_id: 50
+ position {
+ x: 169.81
+ y: 210.65
+ z: 215.83
+ }
+ 36: 1
+ }
+ icon {
+ map_id: 50
+ position {
+ x: 169.81
+ y: 210.65
+ z: 215.83
+ }
+ 36: 1
+ }
+ icon {
+ map_id: 50
+ position {
+ x: 169.81
+ y: 210.65
+ z: 215.83
+ }
+ }
+ icon {
+ map_id: 50
+ position {
+ x: 169.81
+ y: 210.65
+ z: 215.83
+ }
+ }
+ icon {
+ map_id: 50
+ position {
+ x: 169.81
+ y: 210.65
+ z: 215.83
+ }
+ 36: 1
+ }
+ icon {
+ map_id: 50
+ position {
+ x: 169.81
+ y: 210.65
+ z: 215.83
+ }
+ 36: 1
+ }
+ icon {
+ map_id: 50
+ position {
+ x: 169.81
+ y: 210.65
+ z: 215.83
+ }
+ }
+ icon {
+ map_id: 50
+ position {
+ x: 169.81
+ y: 210.65
+ z: 215.83
+ }
+ }
+ id: "(\350\314\006\302\223^\226"
+}
There was a problem hiding this comment. Full Diff--- xml_converter/integration_tests/test_cases/xml_render_on_minimap/output_proto/markers.bin.textproto._old 2024-09-12 03:38:57.834271143 +0000
+++ xml_converter/integration_tests/test_cases/xml_render_on_minimap/output_proto/markers.bin.textproto._new 2024-09-12 03:38:57.842271274 +0000
@@ -0,0 +1,92 @@
+category {
+ name: "My Category"
+ icon {
+ map_id: 50
+ position {
+ x: 169.81
+ y: 210.65
+ z: 215.83
+ }
+ 36: 1
+ }
+ icon {
+ map_id: 50
+ position {
+ x: 169.81
+ y: 210.65
+ z: 215.83
+ }
+ 36: 1
+ }
+ icon {
+ map_id: 50
+ position {
+ x: 169.81
+ y: 210.65
+ z: 215.83
+ }
+ }
+ icon {
+ map_id: 50
+ position {
+ x: 169.81
+ y: 210.65
+ z: 215.83
+ }
+ }
+ icon {
+ map_id: 50
+ position {
+ x: 169.81
+ y: 210.65
+ z: 215.83
+ }
+ 36: 1
+ }
+ icon {
+ map_id: 50
+ position {
+ x: 169.81
+ y: 210.65
+ z: 215.83
+ }
+ 36: 1
+ }
+ icon {
+ map_id: 50
+ position {
+ x: 169.81
+ y: 210.65
+ z: 215.83
+ }
+ }
+ icon {
+ map_id: 50
+ position {
+ x: 169.81
+ y: 210.65
+ z: 215.83
+ }
+ }
+ trail {
+ 33: 1
+ }
+ trail {
+ 33: 1
+ }
+ trail {
+ }
+ trail {
+ }
+ trail {
+ 33: 1
+ }
+ trail {
+ 33: 1
+ }
+ trail {
+ }
+ trail {
+ }
+ id: "(\350\314\006\302\223^\226"
+}
There was a problem hiding this comment. Full Diff--- xml_converter/integration_tests/test_cases/xml_render_on_minimap/output_proto/markers.bin.textproto._old 2024-09-19 03:37:03.438146512 +0000
+++ xml_converter/integration_tests/test_cases/xml_render_on_minimap/output_proto/markers.bin.textproto._new 2024-09-19 03:37:03.445146525 +0000
@@ -0,0 +1,92 @@
+category {
+ name: "My Category"
+ icon {
+ map_id: 50
+ position {
+ x: 169.81
+ y: 210.65
+ z: 215.83
+ }
+ 36: 1
+ }
+ icon {
+ map_id: 50
+ position {
+ x: 169.81
+ y: 210.65
+ z: 215.83
+ }
+ 36: 1
+ }
+ icon {
+ map_id: 50
+ position {
+ x: 169.81
+ y: 210.65
+ z: 215.83
+ }
+ }
+ icon {
+ map_id: 50
+ position {
+ x: 169.81
+ y: 210.65
+ z: 215.83
+ }
+ }
+ icon {
+ map_id: 50
+ position {
+ x: 169.81
+ y: 210.65
+ z: 215.83
+ }
+ 36: 1
+ }
+ icon {
+ map_id: 50
+ position {
+ x: 169.81
+ y: 210.65
+ z: 215.83
+ }
+ 36: 1
+ }
+ icon {
+ map_id: 50
+ position {
+ x: 169.81
+ y: 210.65
+ z: 215.83
+ }
+ }
+ icon {
+ map_id: 50
+ position {
+ x: 169.81
+ y: 210.65
+ z: 215.83
+ }
+ }
+ trail {
+ 33: 1
+ }
+ trail {
+ 33: 1
+ }
+ trail {
+ }
+ trail {
+ }
+ trail {
+ 33: 1
+ }
+ trail {
+ 33: 1
+ }
+ trail {
+ }
+ trail {
+ }
+ id: "(\350\314\006\302\223^\226"
+}
|
Binary file not shown.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| <OverlayData> | ||
| <MarkerCategory DisplayName="My Category" ID="KOjMBsKTXpY=" Name="mycategory"> | ||
| </MarkerCategory> | ||
|
|
||
| <POIs> | ||
| <POI Type="mycategory" MapID="50" XPos="169.809998" YPos="210.649994" ZPos="215.830002" MinimapVisibility="false"/> | ||
| <POI Type="mycategory" MapID="50" XPos="169.809998" YPos="210.649994" ZPos="215.830002" MinimapVisibility="false"/> | ||
| <POI Type="mycategory" MapID="50" XPos="169.809998" YPos="210.649994" ZPos="215.830002" MinimapVisibility="true"/> | ||
| <POI Type="mycategory" MapID="50" XPos="169.809998" YPos="210.649994" ZPos="215.830002" MinimapVisibility="true"/> | ||
| <POI Type="mycategory" MapID="50" XPos="169.809998" YPos="210.649994" ZPos="215.830002" MinimapVisibility="false"/> | ||
| <POI Type="mycategory" MapID="50" XPos="169.809998" YPos="210.649994" ZPos="215.830002" MinimapVisibility="false"/> | ||
| <POI Type="mycategory" MapID="50" XPos="169.809998" YPos="210.649994" ZPos="215.830002" MinimapVisibility="true"/> | ||
| <POI Type="mycategory" MapID="50" XPos="169.809998" YPos="210.649994" ZPos="215.830002" MinimapVisibility="true"/> | ||
| <Trail Type="mycategory" MinimapVisibility="false"/> | ||
| <Trail Type="mycategory" MinimapVisibility="false"/> | ||
| <Trail Type="mycategory" MinimapVisibility="true"/> | ||
| <Trail Type="mycategory" MinimapVisibility="true"/> | ||
| <Trail Type="mycategory" MinimapVisibility="false"/> | ||
| <Trail Type="mycategory" MinimapVisibility="false"/> | ||
| <Trail Type="mycategory" MinimapVisibility="true"/> | ||
| <Trail Type="mycategory" MinimapVisibility="true"/> | ||
| </POIs> | ||
| </OverlayData> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| input_paths: | ||
| "pack": "xml" | ||
| expected_stdout: | | ||
| expected_stderr: | | ||
| expected_returncode: 0 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Full Diff
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this field is used on trails and icons, but only icons are tested here. Lets add a test for trails as well.