Changed render_on_minimap to is_hidden_on_minimap #352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Full Diff
--- xml_converter/integration_tests/test_cases/proto_is_hidden_on_minimap/input/pack/markers.bin.textproto._old 2024-09-11 01:17:56.302697889 +0000
+++ xml_converter/integration_tests/test_cases/proto_is_hidden_on_minimap/input/pack/markers.bin.textproto._new 2024-09-11 01:17:56.310697839 +0000
@@ -0,0 +1,21 @@
+category {
+ name: "My Category"
+ icon {
+ map_id: 50
+ position {
+ x: 169.81
+ y: 210.65
+ z: 215.83
+ }
+ 36: 1
+ }
+ icon {
+ map_id: 50
+ position {
+ x: 169.81
+ y: 210.65
+ z: 215.83
+ }
+ }
+ id: "(\350\314\006\302\223^\226"
+}
There was a problem hiding this comment.
this field is used on trails and icons, but only icons are tested here. Lets add a test for trails as well.
There was a problem hiding this comment.
Full Diff
--- xml_converter/integration_tests/test_cases/proto_is_hidden_on_minimap/output_proto/markers.bin.textproto._old 2024-09-11 01:17:56.318697789 +0000
+++ xml_converter/integration_tests/test_cases/proto_is_hidden_on_minimap/output_proto/markers.bin.textproto._new 2024-09-11 01:17:56.326697739 +0000
@@ -0,0 +1,21 @@
+category {
+ name: "My Category"
+ icon {
+ map_id: 50
+ position {
+ x: 169.81
+ y: 210.65
+ z: 215.83
+ }
+ 36: 1
+ }
+ icon {
+ map_id: 50
+ position {
+ x: 169.81
+ y: 210.65
+ z: 215.83
+ }
+ }
+ id: "(\350\314\006\302\223^\226"
+}
There was a problem hiding this comment.
Full Diff
--- xml_converter/integration_tests/test_cases/xml_render_on_minimap/output_proto/markers.bin.textproto._old 2024-09-11 01:17:56.334697690 +0000
+++ xml_converter/integration_tests/test_cases/xml_render_on_minimap/output_proto/markers.bin.textproto._new 2024-09-11 01:17:56.342697639 +0000
@@ -0,0 +1,72 @@
+category {
+ name: "My Category"
+ icon {
+ map_id: 50
+ position {
+ x: 169.81
+ y: 210.65
+ z: 215.83
+ }
+ 36: 1
+ }
+ icon {
+ map_id: 50
+ position {
+ x: 169.81
+ y: 210.65
+ z: 215.83
+ }
+ 36: 1
+ }
+ icon {
+ map_id: 50
+ position {
+ x: 169.81
+ y: 210.65
+ z: 215.83
+ }
+ }
+ icon {
+ map_id: 50
+ position {
+ x: 169.81
+ y: 210.65
+ z: 215.83
+ }
+ }
+ icon {
+ map_id: 50
+ position {
+ x: 169.81
+ y: 210.65
+ z: 215.83
+ }
+ 36: 1
+ }
+ icon {
+ map_id: 50
+ position {
+ x: 169.81
+ y: 210.65
+ z: 215.83
+ }
+ 36: 1
+ }
+ icon {
+ map_id: 50
+ position {
+ x: 169.81
+ y: 210.65
+ z: 215.83
+ }
+ }
+ icon {
+ map_id: 50
+ position {
+ x: 169.81
+ y: 210.65
+ z: 215.83
+ }
+ }
+ id: "(\350\314\006\302\223^\226"
+}
AsherGlick
requested changes
Sep 11, 2024
There was a problem hiding this comment.
this field is used on trails and icons, but only icons are tested here. Lets add a test for trails as well.
There was a problem hiding this comment.
Full Diff
--- xml_converter/integration_tests/test_cases/proto_is_hidden_on_minimap/input/pack/markers.bin.textproto._old 2024-09-12 03:38:57.778270223 +0000
+++ xml_converter/integration_tests/test_cases/proto_is_hidden_on_minimap/input/pack/markers.bin.textproto._new 2024-09-12 03:38:57.786270355 +0000
@@ -0,0 +1,26 @@
+category {
+ name: "My Category"
+ icon {
+ map_id: 50
+ position {
+ x: 169.81
+ y: 210.65
+ z: 215.83
+ }
+ 36: 1
+ }
+ icon {
+ map_id: 50
+ position {
+ x: 169.81
+ y: 210.65
+ z: 215.83
+ }
+ }
+ trail {
+ 33: 1
+ }
+ trail {
+ }
+ id: "(\350\314\006\302\223^\226"
+}
There was a problem hiding this comment.
Full Diff
--- xml_converter/integration_tests/test_cases/proto_is_hidden_on_minimap/output_proto/markers.bin.textproto._old 2024-09-12 03:38:57.818270880 +0000
+++ xml_converter/integration_tests/test_cases/proto_is_hidden_on_minimap/output_proto/markers.bin.textproto._new 2024-09-12 03:38:57.826271011 +0000
@@ -0,0 +1,26 @@
+category {
+ name: "My Category"
+ icon {
+ map_id: 50
+ position {
+ x: 169.81
+ y: 210.65
+ z: 215.83
+ }
+ 36: 1
+ }
+ icon {
+ map_id: 50
+ position {
+ x: 169.81
+ y: 210.65
+ z: 215.83
+ }
+ }
+ trail {
+ 33: 1
+ }
+ trail {
+ }
+ id: "(\350\314\006\302\223^\226"
+}
There was a problem hiding this comment.
Full Diff
--- xml_converter/integration_tests/test_cases/xml_render_on_minimap/output_proto/markers.bin.textproto._old 2024-09-12 03:38:57.834271143 +0000
+++ xml_converter/integration_tests/test_cases/xml_render_on_minimap/output_proto/markers.bin.textproto._new 2024-09-12 03:38:57.842271274 +0000
@@ -0,0 +1,92 @@
+category {
+ name: "My Category"
+ icon {
+ map_id: 50
+ position {
+ x: 169.81
+ y: 210.65
+ z: 215.83
+ }
+ 36: 1
+ }
+ icon {
+ map_id: 50
+ position {
+ x: 169.81
+ y: 210.65
+ z: 215.83
+ }
+ 36: 1
+ }
+ icon {
+ map_id: 50
+ position {
+ x: 169.81
+ y: 210.65
+ z: 215.83
+ }
+ }
+ icon {
+ map_id: 50
+ position {
+ x: 169.81
+ y: 210.65
+ z: 215.83
+ }
+ }
+ icon {
+ map_id: 50
+ position {
+ x: 169.81
+ y: 210.65
+ z: 215.83
+ }
+ 36: 1
+ }
+ icon {
+ map_id: 50
+ position {
+ x: 169.81
+ y: 210.65
+ z: 215.83
+ }
+ 36: 1
+ }
+ icon {
+ map_id: 50
+ position {
+ x: 169.81
+ y: 210.65
+ z: 215.83
+ }
+ }
+ icon {
+ map_id: 50
+ position {
+ x: 169.81
+ y: 210.65
+ z: 215.83
+ }
+ }
+ trail {
+ 33: 1
+ }
+ trail {
+ 33: 1
+ }
+ trail {
+ }
+ trail {
+ }
+ trail {
+ 33: 1
+ }
+ trail {
+ 33: 1
+ }
+ trail {
+ }
+ trail {
+ }
+ id: "(\350\314\006\302\223^\226"
+}
AsherGlick
approved these changes
Sep 14, 2024
|
This branch now has conflicts |
There was a problem hiding this comment.
Full Diff
--- xml_converter/integration_tests/test_cases/proto_is_hidden_on_minimap/input/pack/markers.bin.textproto._old 2024-09-19 03:37:03.408146459 +0000
+++ xml_converter/integration_tests/test_cases/proto_is_hidden_on_minimap/input/pack/markers.bin.textproto._new 2024-09-19 03:37:03.416146473 +0000
@@ -0,0 +1,26 @@
+category {
+ name: "My Category"
+ icon {
+ map_id: 50
+ position {
+ x: 169.81
+ y: 210.65
+ z: 215.83
+ }
+ 36: 1
+ }
+ icon {
+ map_id: 50
+ position {
+ x: 169.81
+ y: 210.65
+ z: 215.83
+ }
+ }
+ trail {
+ 33: 1
+ }
+ trail {
+ }
+ id: "(\350\314\006\302\223^\226"
+}
There was a problem hiding this comment.
Full Diff
--- xml_converter/integration_tests/test_cases/proto_is_hidden_on_minimap/output_proto/markers.bin.textproto._old 2024-09-19 03:37:03.424146487 +0000
+++ xml_converter/integration_tests/test_cases/proto_is_hidden_on_minimap/output_proto/markers.bin.textproto._new 2024-09-19 03:37:03.431146500 +0000
@@ -0,0 +1,26 @@
+category {
+ name: "My Category"
+ icon {
+ map_id: 50
+ position {
+ x: 169.81
+ y: 210.65
+ z: 215.83
+ }
+ 36: 1
+ }
+ icon {
+ map_id: 50
+ position {
+ x: 169.81
+ y: 210.65
+ z: 215.83
+ }
+ }
+ trail {
+ 33: 1
+ }
+ trail {
+ }
+ id: "(\350\314\006\302\223^\226"
+}
There was a problem hiding this comment.
Full Diff
--- xml_converter/integration_tests/test_cases/xml_render_on_minimap/output_proto/markers.bin.textproto._old 2024-09-19 03:37:03.438146512 +0000
+++ xml_converter/integration_tests/test_cases/xml_render_on_minimap/output_proto/markers.bin.textproto._new 2024-09-19 03:37:03.445146525 +0000
@@ -0,0 +1,92 @@
+category {
+ name: "My Category"
+ icon {
+ map_id: 50
+ position {
+ x: 169.81
+ y: 210.65
+ z: 215.83
+ }
+ 36: 1
+ }
+ icon {
+ map_id: 50
+ position {
+ x: 169.81
+ y: 210.65
+ z: 215.83
+ }
+ 36: 1
+ }
+ icon {
+ map_id: 50
+ position {
+ x: 169.81
+ y: 210.65
+ z: 215.83
+ }
+ }
+ icon {
+ map_id: 50
+ position {
+ x: 169.81
+ y: 210.65
+ z: 215.83
+ }
+ }
+ icon {
+ map_id: 50
+ position {
+ x: 169.81
+ y: 210.65
+ z: 215.83
+ }
+ 36: 1
+ }
+ icon {
+ map_id: 50
+ position {
+ x: 169.81
+ y: 210.65
+ z: 215.83
+ }
+ 36: 1
+ }
+ icon {
+ map_id: 50
+ position {
+ x: 169.81
+ y: 210.65
+ z: 215.83
+ }
+ }
+ icon {
+ map_id: 50
+ position {
+ x: 169.81
+ y: 210.65
+ z: 215.83
+ }
+ }
+ trail {
+ 33: 1
+ }
+ trail {
+ 33: 1
+ }
+ trail {
+ }
+ trail {
+ }
+ trail {
+ 33: 1
+ }
+ trail {
+ 33: 1
+ }
+ trail {
+ }
+ trail {
+ }
+ id: "(\350\314\006\302\223^\226"
+}
21 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.