-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PAY-3748] Fix logged out state #10871
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -63,7 +63,6 @@ export const BaseButton = forwardRef<HTMLButtonElement, BaseButtonProps>( | |
userSelect: 'none', | ||
whiteSpace: 'nowrap', | ||
paddingInline: 0, | ||
'-webkit-padding': 0, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. afaik, this is not actually a thing There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same here btw, but all good |
||
transition: ` | ||
transform ${motion.hover}, | ||
border-color ${motion.hover}, | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -83,14 +83,14 @@ const ${variables.componentName} = forwardRef((${variables.props}, ref) => { | |
other.width = width | ||
} | ||
|
||
const fillColor = other.fill ?? theme.color?.icon[color] ?? 'red' | ||
const fillcolor = other.fill ?? theme.color?.icon[color] ?? 'red' | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. fillcolor is right not fillColor |
||
|
||
${native ? nativeStyles : webStyles} | ||
|
||
other.role = title ? 'img' : undefined | ||
other['aria-hidden'] = title ? undefined : true | ||
|
||
props = {...other, ref, fillColor} | ||
props = {...other, ref, fillcolor} | ||
|
||
${native ? `const Path = animatedProps ? AnimatedPath : RNSVGPath` : ''} | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Heads up I fix this in an open pr, mind dropping?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yea