[PAY-3748] Fix logged out state #10871
Conversation
|
| @@ -83,14 +83,14 @@ const ${variables.componentName} = forwardRef((${variables.props}, ref) => { | |||
| other.width = width | |||
| } | |||
|
|
|||
| const fillColor = other.fill ?? theme.color?.icon[color] ?? 'red' | |||
| const fillcolor = other.fill ?? theme.color?.icon[color] ?? 'red' | |||
There was a problem hiding this comment.
fillcolor is right not fillColor
| @@ -63,7 +63,6 @@ export const BaseButton = forwardRef<HTMLButtonElement, BaseButtonProps>( | |||
| userSelect: 'none', | |||
| whiteSpace: 'nowrap', | |||
| paddingInline: 0, | |||
| '-webkit-padding': 0, | |||
There was a problem hiding this comment.
afaik, this is not actually a thing
There was a problem hiding this comment.
Same here btw, but all good
| @@ -3,7 +3,7 @@ module.exports = { | |||
| titleProp: true, | |||
| descProp: true, | |||
| replaceAttrValues: { | |||
| red: '{props.fillColor}', | |||
| '#FF0000': '{props.fillColor}' | |||
| red: '{props.fillcolor}', | |||
There was a problem hiding this comment.
Heads up I fix this in an open pr, mind dropping?
| @@ -63,7 +63,6 @@ export const BaseButton = forwardRef<HTMLButtonElement, BaseButtonProps>( | |||
| userSelect: 'none', | |||
| whiteSpace: 'nowrap', | |||
| paddingInline: 0, | |||
| '-webkit-padding': 0, | |||
There was a problem hiding this comment.
Same here btw, but all good
There was a problem hiding this comment.
This is probably a philosophical nitpick but I would really like to move away from the model of having dummy wallets doing signatures. I think it's super weird conceptually - the whole idea of signatures should be to prove you are a certain wallet and thus a certain user, but that doesn't really make sense for these dummy wallets.
Conceptually, anyone should be able to use Audius (and the SDK) without a (user) wallet. Like, not that we will make a wallet for you behind the scenes (that our backend won't recognize anyway), but entirely without a wallet.
What's more is dummy wallets make it hard to reason about the wallet that is doing things - should we use this wallet in create user things? Probably not! We want consumers of SDK to ensure the wallets that they use for users are protected by good passwords etc, not just whatever default wallet we spit back out automatically with this timestamp seed. Throwing in this case would help prevent accidental mishaps there.
This PR also doesn't address the main cause of the weird logged out state bug, which in my opinion isn't that we don't have a wallet, but rather that we're trying to sign something without having a wallet.
I propose fixing that here (we can quibble on the impl and logging but this is the gist) and leaving the throwing behavior as-is: #10873
ETA: I won't die on this hill, if we really don't like the throwing behavior feel free to merge as-is
I think this analysis is wrong, but the outcome is something I agree with! |
Description
Even when in a logged out state, we need a hedgehog wallet.
Main change in this PR is to not throw in sdk, but create a wallet object with a throwaway password.
Also fix some minor svg browser errors along the way
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide repro instructions & any configuration.