[PAY-3748] Fix logged out SDK initialization #10873
Conversation
|
|
@raymondjacobson Not 100% confident there's no other places, would have to check for direct usage of the signMessage and ilk. And yeah agreed that it's not a pure migration change |
I'm down to let this go in and see what we find |
| const signature = await audiusWalletClient | ||
| .signMessage({ message }) | ||
| .catch((e) => { | ||
| console.warn(e) |
There was a problem hiding this comment.
probably should not be a warn. will make for a really messy console
There was a problem hiding this comment.
Yeah fwiw this was a quick and dirty impl. I think doing this "right" would be throwing a specific error type and filtering for that specific error before swallowing it (w/o log)
[6928844] Revert tan-query changes on main (#10907) Andrew Mendelsohn [0f13539] [PAY-3750] Remove unused exports and dead code - part 4 (#10903) Farid Salau [fd2da0c] Switch react-lottie for lottie-react (#10905) Raymond Jacobson [4d79dda] [PAY-3750] Remove unused exports and dead code - part 3 (#10902) Farid Salau [3f3cc26] [PAY-3750] Remove unused exports and dead code - part 2 (#10901) Farid Salau [f5fc67b] Fix wrong data getting written to queryClient (#10900) Andrew Mendelsohn [0a000c7] [PAY-3750] Remove dead code in web - part 1 (#10897) Farid Salau [3074cc2] [PAY-3729] Fix issues with cover photos and challenges (#10891) Randy Schott [81f9d83] [C-5588] Replace useGetTrackById usages with useTrack (#10889) Andrew Mendelsohn [b6c0d5f] [PAY-3741] Fix playback immediately after purchase (#10895) Raymond Jacobson [f882ea1] Refactor primeData helpers (#10893) Andrew Mendelsohn [eeaa32d] Fix cache syncing (#10894) Dylan Jeffers [954e931] Misc web package cleanup (#10885) Raymond Jacobson [cf1aff3] [C-5589] Migrate collections to react query (#10886) Dylan Jeffers [6c82c79] Fix mobile prettier (#10888) Dylan Jeffers [067a5ec] [PAY-3740] Stop propagation on gated conditions pill (#10887) Raymond Jacobson [5301258] Fix SSR rendering issues (#10884) Randy Schott [ffdf3bd] [PAY-3739] Fix folder expansion (#10883) Raymond Jacobson [99dc254] [C-5587] Migrate users hooks to react query (#10881) Dylan Jeffers [3c1ce7c] [PAY-3748] Fix logged out SDK initialization (#10873) Marcus Pasell [496e3b4] Fix various console warnings (#10872) Dylan Jeffers [5e8699b] Small fix to mobile edit trackform to show artwork on upload (#10880) Kyle Shanks [553e251] [C-5582] Fix icon fill warning (#10861) Dylan Jeffers [614ece7] [C-5581] Remove default props (#10860) Dylan Jeffers [3ba3784] Fix web tests due to redux-first-history migration (#10874) Dylan Jeffers [2e4ff12] [C-5578] Replace connected-react-router with redux-first-history (#10858) Dylan Jeffers
Description
Alternate fix for PAY-3748 to fix logged out users compared to #10871
This change doesn't resort to dummy wallets and maintains the throwing behavior of AudiusWalletClient, which feels correct.
AudiusWalletClient throws when the user is not logged in and tries to sign something, so catch that when initializing the signature for the Eth relay.
There's an additional bug here in that the eth relay won't have its signature reinitialized on log in. That will require a separate fix.
How Has This Been Tested?
Trending loads.