Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Social: Fix deprecation warnings for WP 6.6 #42634

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

manzoorwanijk
Copy link
Member

Related to #37713

In the editor, we have some warnings like

wp.editPost.PluginPrePublishPanel is deprecated since version 6.6.
Please use wp.editor.PluginPrePublishPanel instead.
wp.editPost.PluginPostPublishPanel is deprecated since version 6.6.
Please use wp.editor.PluginPostPublishPanel instead.

Proposed changes:

  • Fix deprecation warnings in publicize-components for edit-post package for WP 6.6

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

  • Activate the Social plugin and deactivate Jetpack
  • Create a new post using the block editor
  • Open Social sidebar
  • Confirm that all is well
  • Click on Publish
  • Notice the pre-publish panel
  • Confirm that the Social UI looks fine
  • Publish the post
  • Notice the post-publish panel
  • Confirm that it looks fine
  • Confirm that there are no warnings mentioned above

@manzoorwanijk manzoorwanijk added [Type] Task [Status] Needs Team Review Obsolete. Use Needs Review instead. labels Mar 21, 2025
@manzoorwanijk manzoorwanijk requested a review from a team March 21, 2025 07:46
@manzoorwanijk manzoorwanijk self-assigned this Mar 21, 2025
Copy link
Contributor

github-actions bot commented Mar 21, 2025

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack), and enable the fix/social/deprecation-warnings-for-wp-6.6 branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack fix/social/deprecation-warnings-for-wp-6.6

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

Copy link
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

Copy link

jp-launch-control bot commented Mar 21, 2025

Code Coverage Summary

2 files are newly checked for coverage.

File Coverage
projects/js-packages/publicize-components/src/components/post-publish-manual-sharing/index.tsx 0/4 (0.00%) 💔
projects/js-packages/publicize-components/src/components/post-publish-review-prompt/index.tsx 0/15 (0.00%) 💔

Full summary · PHP report · JS report

Coverage check overridden by Covered by non-unit tests Use to ignore the Code coverage requirement check when E2Es or other non-unit tests cover the code .

@manzoorwanijk manzoorwanijk added the Covered by non-unit tests Use to ignore the Code coverage requirement check when E2Es or other non-unit tests cover the code label Mar 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Covered by non-unit tests Use to ignore the Code coverage requirement check when E2Es or other non-unit tests cover the code [Feature] Publicize Now Jetpack Social, auto-sharing [JS Package] Publicize Components RNA [Status] Needs Team Review Obsolete. Use Needs Review instead. [Type] Task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant