Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Intents extension and required entitlements #1159

Merged
merged 9 commits into from
May 30, 2024

Conversation

charliescheer
Copy link
Contributor

Fix

So this is another pre work PR to continue preparing for intents/shortcuts on Mac. In this PR I have done a number of things that should free up the work on that project to continue. Here I have:

  1. I have added an intents extension
  2. Updated the bundle names for debug/release on intents and the main app to what they should be
  3. I have added an app group entitlement to the intents extension and the main app

With this we should be able to move the database to the app group folder so the intents extension can access it and we should be ready to update the development certificates for the last time.

I promise right now, Friday at 3pm, this is the last time I will bug the infrastructure team.... this week....

Test

Nothing to test, make sure the app builds. Confirm things look correct. There will need to be some certificate work done to make this all good, but that will happen elsewhere.

Review

(Required) Add instructions for reviewers. For example:

Only one developer is required to review these changes, but anyone can perform the review.

Release

(Required) Add a concise statement to RELEASE-NOTES.txt if the changes should be included in release notes. Include details about updating the notes in this section. For example:

These changes do not require release notes.

@charliescheer charliescheer added the tooling Related to anything that supports the building & maintaining of the project. label May 24, 2024
@charliescheer charliescheer added this to the 2.21 milestone May 24, 2024
@charliescheer charliescheer self-assigned this May 24, 2024
Copy link
Contributor

@jleandroperez jleandroperez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ App runs correctly
✅ Unit Tests are green
✅ Entitlements for Debug / Release look correct (hopefully I'm not missing anything!!)

:shipit:

@charliescheer charliescheer merged commit b9464ae into trunk May 30, 2024
8 checks passed
@charliescheer charliescheer deleted the charlie/add-intents-extension-again branch May 30, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tooling Related to anything that supports the building & maintaining of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants